Skip to content

[PM-33315] Create @bitwarden/logging#20197

Merged
dani-garcia merged 3 commits intomainfrom
ps/PM-33315-create-bitwarden-logging-angular
Apr 21, 2026
Merged

[PM-33315] Create @bitwarden/logging#20197
dani-garcia merged 3 commits intomainfrom
ps/PM-33315-create-bitwarden-logging-angular

Conversation

@dani-garcia
Copy link
Copy Markdown
Member

@dani-garcia dani-garcia commented Apr 16, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33315

📔 Objective

Create the @bitwarden/logging-angular library, which contains an angular-specific wrapper of FlightRecorder for dependency injection.

📸 Screenshots

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Logo
Checkmarx One – Scan Summary & Detailsc29ea652-0a86-484c-9905-3450953e25fd

Great job! No new security vulnerabilities introduced in this pull request

github-advanced-security[bot]

This comment was marked as resolved.

@dani-garcia dani-garcia force-pushed the ps/PM-33315-create-bitwarden-logging-angular branch from dbe6201 to 1ae6585 Compare April 16, 2026 11:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.96%. Comparing base (087fcd8) to head (bbb2b81).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20197   +/-   ##
=======================================
  Coverage   46.96%   46.96%           
=======================================
  Files        3911     3913    +2     
  Lines      118361   118367    +6     
  Branches    18111    18111           
=======================================
+ Hits        55585    55592    +7     
  Misses      58602    58602           
+ Partials     4174     4173    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dani-garcia dani-garcia added the ai-review-vnext Request a Claude code review using the vNext workflow label Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR scaffolds a new @bitwarden/logging-angular library that exposes FlightRecorderService, an @Injectable subclass of the framework-agnostic FlightRecorder from @bitwarden/logging. The service wires SdkLoadService.Ready automatically so Angular consumers can inject it via DI. The new library follows established monorepo conventions (README, eslint/jest/tsconfig wiring, project.json, CODEOWNERS, tsconfig.base.json path alias, root jest.config.js registration), and the previously flagged alphabetical ordering of the path alias has been addressed.

Code Review Details

No findings. The implementation is minimal and correct: the service's sole responsibility is DI wiring, and the underlying FlightRecorder is already covered by @bitwarden/logging's tests. The co-located spec verifies injectability, root-singleton semantics, and inheritance — which is the appropriate scope for a thin Angular wrapper. No new external dependencies were introduced; the package-lock.json change is standard workspace-link churn.

Base automatically changed from ps/PM-33314-add-flight-recorder to main April 20, 2026 14:14
@dani-garcia dani-garcia force-pushed the ps/PM-33315-create-bitwarden-logging-angular branch from 1ae6585 to b532934 Compare April 20, 2026 14:21
Comment thread tsconfig.base.json Outdated
@dani-garcia dani-garcia requested a review from djsmith85 April 20, 2026 16:40
@dani-garcia dani-garcia marked this pull request as ready for review April 20, 2026 16:40
@dani-garcia dani-garcia requested a review from a team as a code owner April 20, 2026 16:40
Copy link
Copy Markdown
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good!

@sonarqubecloud
Copy link
Copy Markdown

@dani-garcia dani-garcia merged commit dc888f9 into main Apr 21, 2026
137 checks passed
@dani-garcia dani-garcia deleted the ps/PM-33315-create-bitwarden-logging-angular branch April 21, 2026 09:48
jaasen-livefront pushed a commit that referenced this pull request Apr 22, 2026
* [PM-33315] Create @bitwarden/logging

* Reorder tsconfig, fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants