Skip to content

Refactor ChainQuery to be more flexible #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
evanlinjin wants to merge 19 commits into
base: master
Choose a base branch
from

refactor(chain)!: rename `LocalChain::canonicalize` to `run_task`

211be07
Select commit
Loading
Failed to load commit list.
Draft

Refactor ChainQuery to be more flexible #2139

refactor(chain)!: rename `LocalChain::canonicalize` to `run_task`
211be07
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 9, 2026 in 0s

77.29% (-0.08%) compared to 8dd0209

View this Pull Request on Codecov

77.29% (-0.08%) compared to 8dd0209

Details

Codecov Report

❌ Patch coverage is 85.29862% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.29%. Comparing base (8dd0209) to head (211be07).
⚠️ Report is 1594 commits behind head on master.

Files with missing lines Patch % Lines
crates/chain/src/canonical.rs 78.83% 27 Missing and 2 partials ⚠️
crates/chain/src/canonical_task.rs 91.20% 20 Missing and 2 partials ⚠️
crates/chain/src/local_chain.rs 68.00% 15 Missing and 1 partial ⚠️
crates/chain/src/canonical_view_task.rs 91.37% 12 Missing and 3 partials ⚠️
crates/chain/src/indexed_tx_graph.rs 0.00% 8 Missing ⚠️
crates/core/src/block_queries.rs 77.77% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
- Coverage   77.36%   77.29%   -0.08%     
==========================================
  Files          35       31       -4     
  Lines        9035     5945    -3090     
  Branches        0      267     +267     
==========================================
- Hits         6990     4595    -2395     
+ Misses       2045     1277     -768     
- Partials        0       73      +73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov