Adapations to make it work with HYRAX implementation of THREDDS Catalogs#19
Open
steingod wants to merge 6 commits into
Open
Adapations to make it work with HYRAX implementation of THREDDS Catalogs#19steingod wants to merge 6 commits into
steingod wants to merge 6 commits into
Conversation
Author
|
Will remove the usage of removeprefix which isn't available in 3.8. |
Author
|
Not sure why the online test is failing except that I saw NGIX in that site had trouble. removeprefix has been removed. |
Author
|
When would you think this PR would be assessed/addressed? I don't know how to move on but also need the functionality in a service so have to decide on the way forward. |
Author
|
Any thoughts of timeline for checking this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some modifications were needed in order to traverse HYRAX servers using their implementation of THREDDS Catalogs. The PR is tested on some servers in Poland and the US and performs as intended. There are probably insufficiencies in some areas, but this PR addresses the use case I had available.