Allow setting the minimum volume in the UI#392
Open
lukas227 wants to merge 2 commits into
Open
Conversation
offer three different possibilities to return instead of a boolean 1. Silent: Does not trigger a user notification and consider this success (will give a HTTP 200 for requests via POST) 2. Error: This will give a user visible error in the UI (as well as a HTTP 500 for requests via POST) 3. Success: This will give a user visible success message in the UI Make all request types that only fetch data silent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the web interface a bit more silent (less "action completed successfully messages when there are just async data fetches") and add the option to set the minimum volume.
Originally #390 but now properly updated against the dev branch and tested.