Skip to content

oweditdomain: Use variable repr for continuous to discrete transform #7301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ales-erjavec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

oweditdomain: Use variable repr for continuous to discrete transform #7301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Orange/widgets/data/oweditdomain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3122,7 +3122,7 @@ def apply_reinterpret_c(var, tr, data: MArray):
tr = LookupMappingTransform(
var, {v: i for i, v in enumerate(values)}, dtype=np.float64, unknown=np.nan
)
values = tuple(as_string(values))
values = tuple(column_str_repr(var, values))
rvar = Orange.data.DiscreteVariable(
name=var.name, values=values, compute_value=tr
)
Expand Down
2 changes: 1 addition & 1 deletion Orange/widgets/data/tests/test_oweditdomain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1478,7 +1478,7 @@ def test_as_discrete(self):
)
self.assertEqual(tdomain["A"].values, ("a", "b", "c"))
self.assertEqual(tdomain["B"].values, ("0", "1", "2"))
self.assertEqual(tdomain["C"].values, ("0.0", "0.2", "0.25", "1.25"))
self.assertEqual(tdomain["C"].values, ("0", "0.2", "0.25", "1.25"))
self.assertEqual(
tdomain["D"].values,
("00:00:00", "00:03:00",
Expand Down
Loading