Skip to content

Update masurca: adding missing dependencies#64293

Merged
mencian merged 12 commits intobioconda:masterfrom
LiaOb21:update_masurca
Apr 10, 2026
Merged

Update masurca: adding missing dependencies#64293
mencian merged 12 commits intobioconda:masterfrom
LiaOb21:update_masurca

Conversation

@LiaOb21
Copy link
Copy Markdown
Contributor

@LiaOb21 LiaOb21 commented Apr 9, 2026

I'm updating the recipe for masurca as building its nf-core module we realised some dependencies are missing, causing the biocontainer associated with this recipe to not be functional: nf-core/modules#11049

added dependencies:
- cmake
- xz
- ncurses
- openssl
- gdbm
- python
- file
- gzip
- coreutils

Also, I added:

  skip-lints:
    - compiler_needs_stdlib_c  # until https://github.com/bioconda/bioconda-utils/issues/1095 is resolved

as seen in other recipes, as bioconda/bioconda-utils#1095 (comment) still appears to be an issue


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@LiaOb21
Copy link
Copy Markdown
Contributor Author

LiaOb21 commented Apr 9, 2026

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Copy Markdown
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 masurca-4.1.4-ha5bb246_1.conda linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
masurca 4.1.4--ha5bb246_1 GitHub Actions
showImages are in the linux-64 zip file above.gzip -dc images/masurca---4.1.4--ha5bb246_1.tar.gz | docker load

@LiaOb21
Copy link
Copy Markdown
Contributor Author

LiaOb21 commented Apr 9, 2026

Both conda package and docker locally tested and producing expected outputs.

@LiaOb21
Copy link
Copy Markdown
Contributor Author

LiaOb21 commented Apr 9, 2026

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Apr 9, 2026
@LiaOb21
Copy link
Copy Markdown
Contributor Author

LiaOb21 commented Apr 9, 2026

Found problem when testing docker container with jump reads:

./assemble.sh: line 146: /usr/local/bin/filter_alt.pl: cannot execute: required file not found
./assemble.sh: line 148: /usr/local/bin/filter_alt.pl: cannot execute: required file not found

Attempting to resolve by adding find "${PREFIX}/bin" -name "*.pl" -exec sed -i '1s|^#!.*perl.*|#!/usr/bin/env perl|' {} + to build.sh to fix hardcoded perl shebangs to use env

@LiaOb21
Copy link
Copy Markdown
Contributor Author

LiaOb21 commented Apr 9, 2026

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Copy Markdown
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 masurca-4.1.4-ha5bb246_1.conda linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
masurca 4.1.4--ha5bb246_1 GitHub Actions
showImages are in the linux-64 zip file above.gzip -dc images/masurca---4.1.4--ha5bb246_1.tar.gz | docker load

@LiaOb21
Copy link
Copy Markdown
Contributor Author

LiaOb21 commented Apr 9, 2026

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Copy Markdown
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 masurca-4.1.4-ha5bb246_1.conda linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
masurca 4.1.4--ha5bb246_1 GitHub Actions
showImages are in the linux-64 zip file above.gzip -dc images/masurca---4.1.4--ha5bb246_1.tar.gz | docker load

@LiaOb21
Copy link
Copy Markdown
Contributor Author

LiaOb21 commented Apr 9, 2026

Tested locally with both conda and docker with the following input combinations:

  • paired end
  • single end
  • paired end + jump reads
  • paired end + ONT
  • paired end + PacBio
  • pared end + ONT + PacBio

All working

@LiaOb21 LiaOb21 mentioned this pull request Apr 9, 2026
17 tasks
@LiaOb21
Copy link
Copy Markdown
Contributor Author

LiaOb21 commented Apr 9, 2026

@Mergifyio queue

@mergify
Copy link
Copy Markdown

mergify bot commented Apr 9, 2026

queue

☑️ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • sender-permission >= write

@mencian mencian merged commit b9cf5a3 into bioconda:master Apr 10, 2026
6 checks passed
chaitanyakasaraneni pushed a commit to chaitanyakasaraneni/bioconda-recipes that referenced this pull request Apr 10, 2026
* adding missing dependencies

* python

* pin c_stdlib and openssl to try resolve hash mismatch

* remove conda_build_config.yaml to check if the hash mismatch problem gets resolved

* adding conda_build_config.yaml back

* remove {{ stdlib(c) }} originally added due to linting error

* adding skip-lints due to hash problems

* fix hardcoded perl shebangs to use env

* adding gzip to run dependencies

* adding coreutils to run dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please review & merge set to ask for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants