-
Notifications
You must be signed in to change notification settings - Fork 9
Make delivery summary posting optional per program #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
neal-bpm
wants to merge
5
commits into
main
Choose a base branch
from
vn/slack-delivery-summary-optional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ff8ab2f
Make delivery summary posting optional per
neal-bpm 1ecd4fd
Enable delivery summaries for programs with Slack
neal-bpm b45ceaf
Apply suggestion from @cubic-dev-ai[bot]
neal-bpm db5bdb1
Improve delivery summary feature with stricter data constraints
neal-bpm 461da10
Add constraint on send_delivery_summary field
neal-bpm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
priv/repo/migrations/20260512195708_add_send_delivery_summaries_to_programs.exs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| defmodule BikeBrigade.Repo.Migrations.AddSendDeliverySummariesToPrograms do | ||
| use Ecto.Migration | ||
|
|
||
| def change do | ||
| alter table(:programs) do | ||
| add :send_delivery_summaries, :boolean, default: false | ||
|
cubic-dev-ai[bot] marked this conversation as resolved.
|
||
| end | ||
| end | ||
| end | ||
16 changes: 16 additions & 0 deletions
16
...rations/20260519000001_enable_send_delivery_summaries_for_programs_with_slack_channel.exs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| defmodule BikeBrigade.Repo.Migrations.EnableSendDeliverySummariesForProgramsWithSlackChannel do | ||
| use Ecto.Migration | ||
| import Ecto.Query | ||
|
|
||
| alias BikeBrigade.Repo | ||
|
|
||
| def up do | ||
| from(prog in BikeBrigade.Delivery.Program, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Using application schema modules ( Prompt for AI agents |
||
| update: [set: [send_delivery_summaries: true]], | ||
| where: not is_nil(prog.slack_channel_id) | ||
| ) | ||
| |> Repo.update_all([]) | ||
|
neal-bpm marked this conversation as resolved.
|
||
| end | ||
|
|
||
| def down, do: :ok | ||
| end | ||
9 changes: 9 additions & 0 deletions
9
priv/repo/migrations/20260526000001_add_not_null_constraint_to_send_delivery_summaries.exs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| defmodule BikeBrigade.Repo.Migrations.AddNotNullConstraintToSendDeliverySummaries do | ||
| use Ecto.Migration | ||
|
|
||
| def change do | ||
| alter table(:programs) do | ||
| modify :send_delivery_summaries, :boolean, null: false | ||
| end | ||
| end | ||
| end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.