Fixed MI issue #469 . First commit to this project#495
Open
Ash1R wants to merge 3 commits into
Open
Conversation
Contributor
|
Thanks for the patch! Is there a good time we could get on Zoom together and look at this? |
Contributor
Author
|
Sure! I can meet today (Wed Aug 17) at any time, tomorrow and day after tomorrow after 5:30, or any time on the weekend. |
Contributor
Author
|
Hi Ben,
Thanks for looking at my patch! I can meet anytime on the weekend, after
3:30 on Tues-Thurs next week, or after 5:15 on Monday and Friday.
Best,
Ashir
…On Tue, Aug 16, 2022 at 11:49 AM Ben Welsh ***@***.***> wrote:
Thanks for the patch! Is there a good time we could get on Zoom together
and look at this?
—
Reply to this email directly, view it on GitHub
<#495 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQPD7FDGDFLT5FVVFRJECILVZPPDBANCNFSM55W266SQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
I saw that you wanted some changes on the Michigan scraper, so I made them in the correct PR this time |
palewire
requested changes
Nov 29, 2022
Comment on lines
+177
to
+185
| # they use numbers instead of these words in some of the pdf | ||
| if temp[1] == "1": | ||
| temp[1] = "Plant Closing" | ||
| elif temp[1] == "2": | ||
| temp[1] = "Mass Layoff" | ||
| elif temp[1] == "3": | ||
| temp[1] = "" | ||
| elif temp[1] == "4": | ||
| temp[1] = "" |
Contributor
There was a problem hiding this comment.
As discussed in other PRs, we don't want to do any data editing or translation in these scrapers, if we can avoid it. Let's leave these values as is.
stucka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for issue #469 , my first commit to this project.
In summary, there wasn't an easily extractable table, so I had to use the space between columns in each row. There were two categories of pdfs: 2000-2006 and 2007-2015 which had to be processed differently. Each had its own set of rows with irregular spacing that had to be handled in different ways.