refactor: remove zmq and simplify iti lcd system design

crates/bestool/Cargo.toml

@@ -41,6 +41,7 @@ futures = { workspace = true }
 glob = { version = "0.3.3", optional = true }
 hickory-resolver = { version = "0.25.2", optional = true }
 humantime = { version = "2.2.0", optional = true }
+if-addrs = { version = "0.15.0", optional = true }
 indicatif = { workspace = true, optional = true }
 itertools = { workspace = true, optional = true }
 jiff = "0.2.15"
@@ -79,8 +80,8 @@ tracing = { workspace = true }
 upgrade = { version = "2.0.1", optional = true }
 uuid = { version = "1.19.0", features = ["v4"] }
 walkdir = { version = "2.5.0", optional = true }
+zbus = { version = "5.15.0", optional = true, default-features = false, features = ["tokio"] }
 zip = { version = "8.2.0", optional = true, default-features = false, features = ["time"] }
-zmq = { version = "0.10.0", optional = true }
 
 [target.'cfg(windows)'.dependencies]
 tauri-winrt-notification = { version = "0.7.2", optional = true }
@@ -160,13 +161,13 @@ __tamanu = [ # internal feature to enable the tamanu subcommand common code
 ## Iti subcommands
 iti = [ # enable all iti subcommands
 	"iti-battery",
-	"iti-lcd",
+	"iti-display",
 	"iti-temperature",
 ]
 iti-battery = ["__iti", "dep:folktime", "dep:humantime", "dep:rppal"]
-iti-lcd = ["__iti", "dep:ctrlc", "dep:embedded-graphics", "dep:rpi-st7789v2-driver", "dep:sysinfo"]
+iti-display = ["__iti", "iti-battery", "iti-temperature", "dep:embedded-graphics", "dep:if-addrs", "dep:rpi-st7789v2-driver", "dep:sysinfo", "dep:zbus"]
 iti-temperature = ["__iti", "dep:duct", "dep:humantime"]
-__iti = ["dep:zmq"] # internal feature to enable the iti subcommand common code
+__iti = [] # internal alias enabled by every iti-* subcommand
 
 ## Legacy noop features to avoid breaking builds
 tamanu-upgrade = []

crates/bestool/src/actions/iti.rs

@@ -5,6 +5,8 @@ use crate::args::Args;
 
 use super::Context;
 
+pub mod samplers;
+
 /// Tamanu Iti subcommands.
 #[derive(Debug, Clone, Parser)]
 pub struct ItiArgs {
@@ -20,10 +22,8 @@ super::subcommands! {
 
 	#[cfg(feature = "iti-battery")]
 	battery => Battery(BatteryArgs),
-	#[cfg(feature = "iti-lcd")]
-	lcd => Lcd(LcdArgs),
-	#[cfg(feature = "iti-lcd")]
-	sparks => Sparks(SparksArgs),
+	#[cfg(feature = "iti-display")]
+	display => Display(DisplayArgs),
 	#[cfg(feature = "iti-temperature")]
 	temperature => Temperature(TemperatureArgs)
 }