can reflect observers#23797
Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom Apr 16, 2026
Merged
Conversation
mockersf
added
A-ECS
This was referenced Apr 14, 2026
alice-i-cecile
added
D-Trivial
alice-i-cecile
approved these changes
Apr 14, 2026
alice-i-cecile
added
X-Uncontroversial
chescock
reviewed
Apr 15, 2026
chescock
approved these changes
Apr 15, 2026
Contributor
chescock
left a comment
chescock
left a comment
There was a problem hiding this comment.
Looks good! I left a few more thoughts on how we might generalize things more, but none of them should be blocking.
| @@ -37,6 +45,15 @@ pub struct ReflectEvent(ReflectEventFns); | |||
| pub struct ReflectEventFns { | |||
Contributor
There was a problem hiding this comment.
Not for this PR, but will we also want a fn register_event_key(&self, &mut World) -> EventKey, similar to ReflectComponent::register_component?
I think that would make it just possible to construct a completely dynamic observer using Observer::with_dynamic_runner, Observer::with_event_key, and ReflectFromPtr::from_ptr. And the fact that everything would be possible might discourage certain reviewers from trying to overgeneralize the convenience methods :).
alice-i-cecile
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing