This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Bugfix: correcting bitshift order to match ws2811 spec#6
Open
phleech wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst testing this library against a string of 50 WS2811 LED's I noticed that Colour(r, g, b) seemed to be mixing up the red and green channels.
Upon investigation it appears that this is a result of the bit shifting being incorrect.
Excerpt from the WS2811 spec:
This is a breaking change. It now works correctly for my string of LED's but could potentially break for others (especially if they've added work arounds in their code for the issue).