-
-
Notifications
You must be signed in to change notification settings - Fork 40
Updated README to add --locked to commands #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lt25106
wants to merge
5
commits into
bergercookie:master
Choose a base branch
from
lt25106:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6947e19
Updated README to add --locked to commands
lt25106 55e3f74
Update release.yml
lt25106 641bda6
Enable zip option for Windows in release workflow
lt25106 a957167
Update GitHub Actions workflow for multi-platform builds
lt25106 05bec9a
sure aint working
lt25106 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,8 +5,8 @@ permissions: | |
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - v[0-9]+.* | ||
| branches: | ||
| - "*" | ||
|
|
||
| jobs: | ||
| create-release: | ||
|
|
@@ -24,28 +24,59 @@ jobs: | |
| include: | ||
| - target: x86_64-unknown-linux-gnu | ||
| os: ubuntu-latest | ||
| # - target: aarch64-unknown-linux-gnu | ||
| # os: ubuntu-latest | ||
| - target: x86_64-apple-darwin | ||
| os: macos-latest | ||
| - target: aarch64-apple-darwin | ||
| os: macos-latest | ||
| # - target: x86_64-pc-windows-msvc | ||
| # os: windows-latest | ||
| - target: x86_64-pc-windows-msvc | ||
| os: windows-latest | ||
|
|
||
| runs-on: ${{ matrix.os }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| # Install dependencies on Linux | ||
| - name: Install dependencies on Linux | ||
| if: startsWith(matrix.target, 'x86_64-unknown-linux') || startsWith(matrix.target, 'aarch64-unknown-linux') | ||
| run: sudo apt-get update && sudo apt-get install -y make openssl libssl-dev | ||
| # Install deps (Linux) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we can get binary releases working on Windows that would be wonderful! I'm pretty wary of these changes however. I'll need to see a passing run of this updated workflow on your fork of asm-lsp before this will be ok to merge. |
||
| - name: Install dependencies (Linux) | ||
| if: runner.os == 'Linux' | ||
| run: sudo apt-get update && sudo apt-get install -y make openssl libssl-dev pkg-config | ||
|
|
||
| # Install Rust target | ||
| - name: Install Rust target | ||
| run: rustup target add ${{ matrix.target }} | ||
|
|
||
| # Build REAL LSP binary | ||
| - name: Build asm-lsp (LSP server) | ||
| run: cargo build --release --bin asm-lsp --target ${{ matrix.target }} | ||
|
|
||
| # Package binary | ||
| - name: Package binary (unix) | ||
| if: runner.os != 'Windows' | ||
| run: | | ||
| mkdir dist | ||
| cp target/${{ matrix.target }}/release/asm-lsp dist/ | ||
| tar -czf asm-lsp-${{ matrix.target }}.tar.gz -C dist asm-lsp | ||
|
|
||
| # Upload Rust binaries | ||
| - uses: taiki-e/upload-rust-binary-action@v1 | ||
| - name: Package binary (windows) | ||
| if: runner.os == 'Windows' | ||
| run: | | ||
| mkdir dist | ||
| copy target\${{ matrix.target }}\release\asm-lsp.exe dist\ | ||
| powershell Compress-Archive dist\asm-lsp.exe asm-lsp-${{ matrix.target }}.zip | ||
|
|
||
| # Upload to release | ||
| - name: Upload (unix) | ||
| if: runner.os != 'Windows' | ||
| uses: softprops/action-gh-release@v1 | ||
| with: | ||
| bin: asm-lsp | ||
| target: ${{ matrix.target }} | ||
| tar: unix | ||
| # zip: windows | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| files: asm-lsp-${{ matrix.target }}.tar.gz | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Upload (windows) | ||
| if: runner.os == 'Windows' | ||
| uses: softprops/action-gh-release@v1 | ||
| with: | ||
| files: asm-lsp-${{ matrix.target }}.zip | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only running the release flow when a tag is pushed that matches a semver version is intentional, this change should be reverted.