Revert "Reuse a shared Rayon pool during RSRS factorization"#8
Merged
Conversation
This reverts commit 586b05b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts PR #7 (Reuse a shared Rayon pool during RSRS factorization).
The change did not alter the algorithm itself, but it did change thread lifetime and process behavior: instead of creating short-lived Rayon pools for individual RSRS phases, it stores a long-lived custom thread pool inside each Rsrs instance. In our server environment this appears to trigger SIGBUS failures. The risk comes from keeping a persistent pool alive with large per-thread stacks (128 MiB) and a thread count that defaults to all CPUs, which significantly changes the process’s memory/thread footprint and is especially fragile in embedded or pre-fork server setups.
Reverting restores the previous transient-pool behavior, which is less efficient but has been stable in production.