Dummy backend: implement Documents/Desktop/Pictures stubs; print docu…#3553
Open
bekarys2003 wants to merge 3 commits intobeeware:mainfrom
Open
Dummy backend: implement Documents/Desktop/Pictures stubs; print docu…#3553bekarys2003 wants to merge 3 commits intobeeware:mainfrom
bekarys2003 wants to merge 3 commits intobeeware:mainfrom
Conversation
40c3d80 to
a54203a
Compare
freakboy3742
requested changes
Jun 13, 2025
Member
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for the PR; however, as CI is showing, there's a lot of problems here.
First is that you've added an implementation for the dummy backend, and tests, but you haven't added the public interface layer (in the core module). It's the core module that exposes paths.* as something that can be accessed.
More importantly - adding this to Dummy is an important first step, but we're also going to need implementations for macOS, Windows and Linux - and exception-raising versions for other platforms. We're unlikely to accept a PR that adds an API, but then only implements in on the test platform.
| @@ -0,0 +1 @@ | |||
| Implement Documents, Desktop & Pictures paths in the Dummy backend and update the simple test app to print them. | |||
Member
There was a problem hiding this comment.
A couple of comments here:
- This should be
3551.feature.rstfile - it's a new feature, not a miscellanous update; and it's RST content - It should be phrased in the form of a release note:
Suggested change
| Implement Documents, Desktop & Pictures paths in the Dummy backend and update the simple test app to print them. | |
| App paths now expose locations for Documents, Desktop & Pictures folders. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ments in simple test app
This patch adds implementations for get_documents_path, get_desktop_path, and get_pictures_path in the Dummy backend so that app.paths.documents, app.paths.desktop, and app.paths.pictures resolve to the user’s ~/Documents, ~/Desktop, and ~/Pictures directories, respectively. It also updates the simple testbed app to print out the documents path (and optionally desktop/pictures) so that the existing user‐space path integration tests pass in non‐interactive mode.
Fixes #3551
PR Checklist: