-
-
Notifications
You must be signed in to change notification settings - Fork 14
Add support for ARM64 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
baf4887
173f9a4
d7a2c7e
102420e
8d2e6e9
9f42370
f8caeda
e1ce74b
d4e846f
7267944
b4ef03c
0996e32
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,8 @@ | |
| "post_install_script": "", | ||
| "pre_uninstall_script": "", | ||
| "python_version": "3.X.0", | ||
| "host_arch": "AMD64", | ||
| "configuration": "{{ 'ARM64' if cookiecutter.host_arch == 'ARM64' else 'x64' }}", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "configuration" is a little vague here - and internal to VSCode, I think "Configuration" is more about "Release" or "Debug"; maybe "vscode_platform"? |
||
| "_extensions": [ | ||
| "briefcase.integrations.cookiecutter.PythonVersionExtension", | ||
| "briefcase.integrations.cookiecutter.UUIDExtension", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| {% if cookiecutter.host_arch == 'ARM64' %} | ||
| <package id="pythonarm64" version="{{ cookiecutter.python_version|nuget_version }}" targetFramework="native" /> | ||
| {% else %} | ||
| <package id="python" version="{{ cookiecutter.python_version|nuget_version }}" targetFramework="native" /> | ||
| {% endif %} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there no way for this to contain both, selected conditionally on which target is being used? Or, alternatively - produce two packages.config files selecting the right file as appropriate? It seems weird to have a VSCode file that works for both architectures, but a packages.config that only works for one.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I couldn't find a way to do it dynamically. Looks like Visual Studio supports an alternative way of specifying packages in the project file (PackageReference) but the Platform property doesn't appear to be supported there. |
||
| </packages> | ||
Uh oh!
There was an error while loading. Please reload this page.