feat(session): open barrels, ender chests and shulker boxes - #155
Open
xRookieFight wants to merge 1 commit into
Open
feat(session): open barrels, ender chests and shulker boxes#155xRookieFight wants to merge 1 commit into
xRookieFight wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only a chest opened. Barrels, trapped chests, shulker boxes and ender chests were registered blocks that did nothing when clicked, and the storage path was written around the one block that worked.
block.container_kind. Adding a container is a registration rather than another branch in the session.Related issue
Part of #130
Double chests are not in this PR. Pairing is not a server-side decision the client will follow: it reads
pairx/pairzoff the two chest block entities, and without writing those the client draws 27 slots however many the server offers - which would leave half a double chest unreachable. It needs chest block-entity data first.Shulker boxes also still drop their contents like any other container rather than keeping them in the item, which needs item NBT round-tripping (#120).
Checklist
v -check .is cleanv test server/block,server/player, and the session inventory/items/blocks/place/break tests are greenpub/capitalized exports, no import cycles, minimal comments)world_call/wr.submit/WorldTx), never through a global Hub actor