Skip to content
Draft
Show file tree
Hide file tree
Changes from 73 commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
786bec4
chore(app-gateway): vendor linkerd and envoy gateway charts with vers…
oscdjj May 15, 2026
1548f2c
feat(cli): bootstrap app-gateway install stack and mesh scaffolding
oscdjj May 15, 2026
0ecead7
fix(cli): satisfy go vet printf checks
oscdjj May 15, 2026
2fb2cbb
chore(app-gateway): sync go module manifests
oscdjj May 15, 2026
c4bee5a
feat(app-gateway): add gateway framework scaffold and vendor packaging
oscdjj May 15, 2026
a90f9ba
chore(cli): require local app-gateway module for mesh install
oscdjj May 15, 2026
2ec3a5f
feat(app-service): reconcile linkerd mesh network policies
oscdjj May 18, 2026
3e5eb6b
feat(cli): bootstrap linkerd mesh network policy fallback
oscdjj May 18, 2026
c5d2d3a
feat(cli): maintain linkerd identity PKI and issuer
oscdjj May 18, 2026
db38eda
feat(cli): optional linkerd-viz install without bundled prometheus
oscdjj May 19, 2026
bf39743
fix(cli): use installer-only paths for viz and vendor assets
oscdjj May 19, 2026
ff2bf1f
feat(app-gateway): add mesh and envoyproxy defaults
oscdjj May 20, 2026
008c6b4
feat(app-gateway): render envoyproxy for linkerd data plane
oscdjj May 20, 2026
1fbc47d
feat(cli): add app-gateway helm wait and mesh helpers
oscdjj May 20, 2026
0a8264e
chore(app-gateway): add mesh verification script
oscdjj May 20, 2026
aa8d2d7
feat(app-gateway): add stable app-gateway-data service for l4 upstream
oscdjj May 20, 2026
0229b00
feat(app-service): add sharedrouteregistry crd and reconcile writer
oscdjj May 20, 2026
50e9ba8
feat(l4-bfl-proxy): route gateway-mode shared apps to app-gateway-data
oscdjj May 20, 2026
b3cef71
test(app-gateway): add phase-a shared external access e2e gate
oscdjj May 20, 2026
00c35f3
feat(app-service): add clusterconfig and per-viewer shared url helpers
oscdjj May 20, 2026
cc7c46f
feat(app-service): add per-entrance srr and logical host regex routes
oscdjj May 20, 2026
4193972
test(app-gateway): add per-viewer shared v2 e2e gate script
oscdjj May 20, 2026
88820ba
chore(app-gateway): add linkerd-viz trust-bundle recovery script
oscdjj May 20, 2026
9a81444
feat(app-service): add shared route registry host reconciliation and …
oscdjj May 21, 2026
1e3e213
feat(authz): wire ext-authz security policy and authz server backend
oscdjj May 21, 2026
298a6e8
fix(cli): improve mesh wait and chart-only networkpolicy bootstrap
oscdjj May 21, 2026
9b3eadf
feat(app-gateway): add demo gateway workloads and httproute samples
oscdjj May 15, 2026
15ef986
fix(app-service): allow ext-authz baseline for non-v2 hostnames
oscdjj May 21, 2026
1fdbd96
feat(app-service): allow cluster-scoped apps on shared gateway path
oscdjj May 21, 2026
bec45f6
fix(app-service): complete route control for cluster-scoped pilots
oscdjj May 21, 2026
ecc53a9
feat(app-service): add shared workload mesh policy and route-mode aut…
oscdjj May 22, 2026
98d145d
feat(sys-event): build coredns allowlist for shared in-cluster from srr
oscdjj May 25, 2026
2c6c2f4
feat(sys-event): wire srr-driven shared in-cluster coredns allowlist
oscdjj May 25, 2026
2895772
feat(routecontrol): sync per-viewer tls secret from zone-ssl-config
oscdjj May 25, 2026
288e74d
feat(security): add caller egress networkpolicy builders
oscdjj May 26, 2026
ccaf660
feat(routecontrol): add caller linkerd inject with safe np ordering
oscdjj May 26, 2026
5d0f5c5
feat(app-service): wire caller reconciler and entrance tls controller
oscdjj May 26, 2026
7894d62
test(authz): cover l5d-client-id parsing and viewer derivation
oscdjj May 26, 2026
4a931a3
test(authz): cover in-cluster identity deciders and denial codes
oscdjj May 26, 2026
f2fc86d
feat(sys-event): gate in-cluster coredns by clusterconfig switch
oscdjj May 26, 2026
4944707
feat(app-service): enforce caller manifest contract for in-cluster ga…
oscdjj May 26, 2026
b3a7c6e
feat(authz): add ext-authz audit logs and prometheus metrics
oscdjj May 26, 2026
51f988b
fix(app-service): add caller dns and middleware egress policies
oscdjj May 26, 2026
b08d3d2
feat(security): np-minimal for cluster-internal shared access
oscdjj May 26, 2026
03c2102
fix(sandbox): exempt linkerd-proxy uid from olares-envoy capture
oscdjj May 26, 2026
f8137c3
fix(authz): harden shared host-user header parsing
oscdjj May 27, 2026
bdbab8d
feat(l4-bfl-proxy): add per-viewer shared vhost and host-user access log
oscdjj May 20, 2026
21a3937
fix(routecontrol): backfill shared ingress policy and stabilize phase…
oscdjj May 27, 2026
f5d0025
feat(app-gateway): add app-service ext-authz fail-closed backend
oscdjj May 20, 2026
3b4581a
feat(routecontrol): freeze in-cluster strong-id service port
oscdjj Jun 1, 2026
acdd586
chore(app-service): sync go module manifests
oscdjj Jun 1, 2026
2492eb3
feat(app-service): wire d2 offloader for v3 shared admission
oscdjj Jun 1, 2026
5072c66
feat(routecontrol): add tls replica fan-out and watchers
oscdjj Jun 2, 2026
2a55f58
feat(app-service): add d2 inject fail-open sentinels and skip metric
oscdjj Jun 2, 2026
7d79e57
test(app-service): cover d2 inject fail-open classification
oscdjj Jun 2, 2026
87f29a9
chore(ci): add d2 sidecar image dockerfile and publish workflow
oscdjj Jun 2, 2026
b974b1b
feat(app-service): bump shared entrance workload on tls replica change
oscdjj Jun 2, 2026
31cea0f
refactor(app-service): extract caller resolve to pkg/gateway
oscdjj Jun 4, 2026
dabf6fa
test(app-service): characterization for caller resolve extraction
oscdjj Jun 4, 2026
2e7dd68
test(app-service): cover caller-mode viewer resolver
oscdjj Jun 4, 2026
981ea82
feat(app-service): add shared-hosts derivation helpers and metrics
oscdjj Jun 4, 2026
42cfb62
feat(app-service): add shared-hosts configmap reconciler
oscdjj Jun 4, 2026
c1e4ef9
test(app-service): cover shared-hosts reconciler
oscdjj Jun 4, 2026
e685da9
feat(app-service): add tls-replica mount guard webhook
oscdjj Jun 4, 2026
5458810
feat(app-service): wire tls-replica mount-guard validating webhook
oscdjj Jun 4, 2026
c9d7c52
test(app-service): cover tls-replica mount guard
oscdjj Jun 4, 2026
be844de
fix(cli): make vendor optional for maintain-linkerd-pki
oscdjj Jun 8, 2026
39e543a
fix(app-service): unify per-entrance SRR appid to name-derived id
oscdjj Jun 8, 2026
73f089d
test(app-service): cover appid divergence not pruned for per-entrance…
oscdjj Jun 8, 2026
f29661c
feat(app-gateway): migrate to app-gateway-system chart packaging
oscdjj Jun 9, 2026
b202071
feat(cli): switch install and upgrade flow to app-gateway-system
oscdjj Jun 9, 2026
c861d55
feat(app-gateway): add linkerd PKI guardian controller integration
oscdjj Jun 9, 2026
b111b49
chore(cli): remove deprecated app-gateway maintenance commands
oscdjj Jun 9, 2026
82b1476
test(app-gateway): add install upgrade smoke tests
oscdjj Jun 10, 2026
669398c
feat(sys-event): merge shared incluster viewer templates and add core…
oscdjj Jun 10, 2026
1c570c2
chore(merge): reconcile unified-auth branch with main IsShared split
oscdjj Jun 10, 2026
1064c71
fix(app-gateway): inject linkerd pki into system chart values
oscdjj Jun 10, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
framework/app-gateway/upstream-charts/** linguist-vendored
2 changes: 1 addition & 1 deletion .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
bash build/package.sh

- name: Run chart-testing (lint)
run: ct lint --chart-dirs .dist/wizard/config,.dist/wizard/config/apps,.dist/wizard/config/gpu --check-version-increment=false --all --validate-maintainers=false
run: ct lint --chart-dirs .dist/wizard/config,.dist/wizard/config/apps,.dist/wizard/config/gpu,.dist/wizard/config/app-gateway-system --check-version-increment=false --all --validate-maintainers=false

test-version:
needs: check-permission
Expand Down
51 changes: 51 additions & 0 deletions .github/workflows/module_appgateway_publish_pki_guardian.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
name: Publish app-gateway linkerd-pki-guardian to Dockerhub

on:
workflow_dispatch:
inputs:
tags:
description: "Release tag (must not be latest)"
required: true

jobs:
publish_pki_guardian:
runs-on: ubuntu-latest
outputs:
digest: ${{ steps.build.outputs.digest }}
steps:
- name: Check out the repo
uses: actions/checkout@v3

- name: Validate tag input
run: |
if [ "${{ github.event.inputs.tags }}" = "latest" ]; then
echo "tag 'latest' is forbidden"
exit 1
fi

- name: Set up QEMU
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Log in to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASS }}

- name: Build and push multi-arch linkerd-pki-guardian image
id: build
uses: docker/build-push-action@v3
with:
push: true
tags: beclab/linkerd-pki-guardian:${{ github.event.inputs.tags }}
file: framework/app-gateway/cmd/linkerd-pki-guardian/Dockerfile
context: framework/app-gateway
platforms: linux/amd64,linux/arm64

- name: Print digest for chart image pin
run: |
echo "Published image digest: beclab/linkerd-pki-guardian@${{ steps.build.outputs.digest }}"
echo "Pin this digest in app-gateway-system values.yaml linkerdPkiGuardian.image.digest"
55 changes: 55 additions & 0 deletions .github/workflows/module_appservice_publish_d2sidecar.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: Publish app-service d2 sidecar to Dockerhub

on:
workflow_dispatch:
inputs:
tags:
description: "Release tag suffix (must not be latest)"
required: true

jobs:
publish_d2_sidecar:
runs-on: ubuntu-latest
outputs:
digest: ${{ steps.build.outputs.digest }}
steps:
- name: Check out the repo
uses: actions/checkout@v3

- name: Validate tag input
run: |
if [ "${{ github.event.inputs.tags }}" = "latest" ]; then
echo "tag 'latest' is forbidden"
exit 1
fi

- name: Set up QEMU
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Log in to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASS }}

- name: Build and push multi-arch d2 sidecar image
id: build
uses: docker/build-push-action@v3
with:
push: true
tags: beclab/nginx:${{ github.event.inputs.tags }}-alpine-njs-olares
file: framework/app-service/Dockerfile.d2sidecar
context: framework/app-service
platforms: linux/amd64,linux/arm64
build-args: |
NJS_OLARES_REV=${{ github.event.inputs.tags }}
SOURCE_COMMIT=${{ github.sha }}
BUILD_DATE=${{ github.run_id }}

- name: Print digest for constants.D2SidecarImageDigest
run: |
echo "Published image digest: beclab/nginx@${{ steps.build.outputs.digest }}"
echo "Use this value in constants.D2SidecarImageDigest"
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ cli/olares-cli*

framework/app-service/bin

# Legacy generated tree (vendor source: .olares/config/app-gateway-vendor/)
framework/app-gateway/vendor-charts/

/files/
market/
user-service/
Expand Down
128 changes: 128 additions & 0 deletions build/assemble-app-gateway-system.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
#!/usr/bin/env bash

set -euo pipefail

BASE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
REPO_ROOT="$(cd "${BASE_DIR}/.." && pwd)"

UPSTREAM_LOCK="${REPO_ROOT}/framework/app-gateway/upstream-charts/UPSTREAM.lock.yaml"
UPSTREAM_DIR="${REPO_ROOT}/framework/app-gateway/upstream-charts"
SYSTEM_DIR="${REPO_ROOT}/framework/app-gateway/.olares/config/app-gateway-system"
CHARTS_DIR="${SYSTEM_DIR}/charts"
CRDS_DIR="${SYSTEM_DIR}/crds"
VALUES_FILE="${SYSTEM_DIR}/values.yaml"
VALUES_SRC_DIR="${REPO_ROOT}/framework/app-gateway/vendor-charts-values"

required_paths=(
"${UPSTREAM_LOCK}"
"${UPSTREAM_DIR}/linkerd-control-plane-chart"
"${UPSTREAM_DIR}/linkerd-crds-chart"
"${UPSTREAM_DIR}/envoy-gateway-helm"
"${UPSTREAM_DIR}/envoy-gateway-crds-helm"
"${SYSTEM_DIR}/Chart.yaml"
"${VALUES_FILE}"
"${VALUES_SRC_DIR}/linkerd-values.yaml"
"${VALUES_SRC_DIR}/envoy-gateway-values.yaml"
"${VALUES_SRC_DIR}/linkerd-crds-values.yaml"
"${VALUES_SRC_DIR}/envoy-gateway-crds-values.yaml"
)

for path in "${required_paths[@]}"; do
if [ ! -e "${path}" ]; then
echo "missing required path: ${path}" >&2
exit 1
fi
done

lock_linkerd_version="$(awk -F'"' '/^linkerd_edge_chart_version:/ {print $2; exit}' "${UPSTREAM_LOCK}")"
lock_envoy_version="$(awk -F'"' '/^envoy_gateway:/ {print $2; exit}' "${UPSTREAM_LOCK}")"

if [ -z "${lock_linkerd_version}" ] || [ -z "${lock_envoy_version}" ]; then
echo "failed to parse chart versions from ${UPSTREAM_LOCK}" >&2
exit 1
fi

rm -rf "${CHARTS_DIR}" "${CRDS_DIR}"
mkdir -p "${CHARTS_DIR}" "${CRDS_DIR}"

for chart in linkerd-control-plane-chart linkerd-crds-chart envoy-gateway-helm envoy-gateway-crds-helm; do
cp -a "${UPSTREAM_DIR}/${chart}" "${CHARTS_DIR}/"
done

mkdir -p "${CRDS_DIR}/linkerd-crds" "${CRDS_DIR}/envoy-gateway-crds"
cp -a "${UPSTREAM_DIR}/linkerd-crds-chart" "${CRDS_DIR}/linkerd-crds/chart"
cp -a "${UPSTREAM_DIR}/envoy-gateway-crds-helm" "${CRDS_DIR}/envoy-gateway-crds/chart"
cp -f "${VALUES_SRC_DIR}/linkerd-crds-values.yaml" "${CRDS_DIR}/linkerd-crds/values.yaml"
cp -f "${VALUES_SRC_DIR}/envoy-gateway-crds-values.yaml" "${CRDS_DIR}/envoy-gateway-crds/values.yaml"

dependency_version() {
local alias_name="$1"
awk -v alias_name="${alias_name}" '
$1 == "-" && $2 == "name:" {in_dep=1; alias=""; version=""; next}
in_dep && $1 == "alias:" {alias=$2; next}
in_dep && $1 == "version:" {
version=$2
if (alias == alias_name) {
gsub(/"/, "", version)
print version
exit
}
next
}
' "${SYSTEM_DIR}/Chart.yaml"
}

dependency_linkerd_version="$(dependency_version "linkerd")"
dependency_envoy_version="$(dependency_version "envoy-gateway")"

if [ "${dependency_linkerd_version}" != "${lock_linkerd_version}" ]; then
echo "app-gateway-system dependency linkerd version mismatch: got ${dependency_linkerd_version}, want ${lock_linkerd_version}" >&2
exit 1
fi

if [ "${dependency_envoy_version}" != "${lock_envoy_version}" ]; then
echo "app-gateway-system dependency envoy-gateway version mismatch: got ${dependency_envoy_version}, want ${lock_envoy_version}" >&2
exit 1
fi

python3 - "${VALUES_FILE}" "${VALUES_SRC_DIR}" <<'PY'
import pathlib
import sys
import yaml

values_file = pathlib.Path(sys.argv[1])
values_src = pathlib.Path(sys.argv[2])

with values_file.open("r", encoding="utf-8") as f:
values = yaml.safe_load(f) or {}

with (values_src / "linkerd-values.yaml").open("r", encoding="utf-8") as f:
linkerd_values = yaml.safe_load(f) or {}

with (values_src / "envoy-gateway-values.yaml").open("r", encoding="utf-8") as f:
envoy_values = yaml.safe_load(f) or {}

values["linkerd"] = linkerd_values
values["envoy-gateway"] = envoy_values

linkerd = values.setdefault("linkerd", {})
identity = linkerd.setdefault("identity", {})
issuer = identity.setdefault("issuer", {})
tls = issuer.setdefault("tls", {})

placeholder_cert = "-----BEGIN CERTIFICATE-----\nPLACEHOLDER\n-----END CERTIFICATE-----\n"
placeholder_key = "-----BEGIN PRIVATE KEY-----\nPLACEHOLDER\n-----END PRIVATE KEY-----\n"

if not tls.get("crtPEM"):
tls["crtPEM"] = placeholder_cert
if not tls.get("keyPEM"):
tls["keyPEM"] = placeholder_key
if not linkerd.get("identityTrustAnchorsPEM"):
linkerd["identityTrustAnchorsPEM"] = placeholder_cert

with values_file.open("w", encoding="utf-8") as f:
f.write("# AUTO-GENERATED by build/assemble-app-gateway-system.sh\n")
yaml.safe_dump(values, f, sort_keys=False)
PY

echo "assembled app-gateway-system chart assets"
1 change: 1 addition & 0 deletions build/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ if [[ "${REPO_PATH}" != "" && "$REPO_PATH" != "/" ]]; then
fi


bash ${BASE_DIR}/assemble-app-gateway-system.sh
DIST_PATH=${DIST_PATH} bash ${BASE_DIR}/package.sh

bash ${BASE_DIR}/image-manifest.sh
Expand Down
7 changes: 7 additions & 0 deletions build/package.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/usr/bin/env bash


BASE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"


function run_cmd(){
echo "$*"
Expand Down Expand Up @@ -76,6 +78,11 @@ run_cmd "cp -rf framework/bfl/.olares/config/launcher ${DIST}/wizard/config/"
echo "packaging gpu ..."
run_cmd "cp -rf infrastructure/gpu/.olares/config/gpu ${DIST}/wizard/config/"

echo "assembling app-gateway-system chart ..."
run_cmd "bash build/assemble-app-gateway-system.sh"

echo "packaging app-gateway system ..."
run_cmd "cp -rf framework/app-gateway/.olares/config/app-gateway-system ${DIST}/wizard/config/"

echo "packaging env config ..."
run_cmd "cp -rf build/system-env.yaml ${DIST}/system-env.yaml"
Expand Down
4 changes: 3 additions & 1 deletion cli/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module github.com/beclab/Olares/cli
go 1.24.11

replace (
github.com/beclab/Olares/framework/app-gateway => ../framework/app-gateway
github.com/beclab/Olares/framework/oac => ../framework/oac
github.com/estesp/manifest-tool/v2 => github.com/estesp/manifest-tool/v2 v2.0.3
olares.com/backups-sdk => github.com/Above-Os/backups-sdk v0.1.40
Expand All @@ -12,9 +13,10 @@ require (
github.com/Masterminds/semver/v3 v3.4.0
github.com/PaesslerAG/jsonpath v0.1.1
github.com/alecthomas/assert/v2 v2.11.0
github.com/beclab/Olares/framework/app-gateway v0.0.0
github.com/beclab/Olares/framework/app-service v0.0.0-20260311124303-23a6533bc2ad
github.com/beclab/Olares/framework/oac v0.0.0-00010101000000-000000000000
github.com/beclab/api v0.0.13
github.com/beclab/api v0.0.14
github.com/cavaliergopher/grab/v3 v3.0.1
github.com/containerd/containerd v1.7.29
github.com/decentralized-identity/web5-go v0.25.0
Expand Down
4 changes: 2 additions & 2 deletions cli/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2 h1:DklsrG3d
github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2/go.mod h1:WaHUgvxTVq04UNunO+XhnAqY/wQc+bxr74GqbsZ/Jqw=
github.com/beclab/Olares/framework/app-service v0.0.0-20260311124303-23a6533bc2ad h1:nmQCNbJNtgTqcusySeeyd9LQOK2jyk78QAjzmvyyPYg=
github.com/beclab/Olares/framework/app-service v0.0.0-20260311124303-23a6533bc2ad/go.mod h1:D9wl7y3obLqXMqfubMROMgdxWAwInnKNrFC//d0nyIA=
github.com/beclab/api v0.0.13 h1:j1mD9jEM8blE2ZhJigCe0B0X9APX0sHH0plGlBSOjak=
github.com/beclab/api v0.0.13/go.mod h1:okd0RExsvSsuW5MsRh7v56Xex3vi5B26xHOGH3LT6yQ=
github.com/beclab/api v0.0.14 h1:/KGHYsb1TpWzOLws2JfPhxpa0tOK9ZyLSDJlBZmY8ko=
github.com/beclab/api v0.0.14/go.mod h1:okd0RExsvSsuW5MsRh7v56Xex3vi5B26xHOGH3LT6yQ=
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
github.com/blang/semver/v4 v4.0.0 h1:1PFHFE6yCCTv8C1TeyNNarDzntLi7wMI5i/pzqYIsAM=
Expand Down
4 changes: 2 additions & 2 deletions cli/pkg/common/kube_runtime.go
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ func (a *Argument) SetMinikubeProfile(profile string) {
a.MinikubeProfile = profile
if profile == "" && a.SystemInfo.IsDarwin() {
fmt.Printf("\nNote: Minikube profile is not set, will try to use the default profile: \"%s\"\n", MinikubeDefaultProfile)
fmt.Println("if this is not expected, please specify it explicitly by setting the --profile/-p option\n")
fmt.Println("if this is not expected, please specify it explicitly by setting the --profile/-p option")
a.MinikubeProfile = MinikubeDefaultProfile
}
}
Expand All @@ -324,7 +324,7 @@ func (a *Argument) SetWSLDistribution(distribution string) {
a.WSLDistribution = distribution
if distribution == "" && a.SystemInfo.IsWindows() {
fmt.Printf("\nNote: WSL distribution is not set, will try to use the default distribution: \"%s\"\n", WSLDefaultDistribution)
fmt.Println("if this is not expected, please specify it explicitly by setting the --distribution/-d option\n")
fmt.Println("if this is not expected, please specify it explicitly by setting the --distribution/-d option")
a.WSLDistribution = WSLDefaultDistribution
}
}
Expand Down
2 changes: 1 addition & 1 deletion cli/pkg/kubesphere/minikube.go
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ func (t *PatchCoreDNSSVC) Execute(runtime connector.Runtime) error {
coreDNSSVCPatchFilePath := filepath.Join(runtime.GetInstallerDir(), "deploy/patch-k3s.yaml")
_, err := runtime.GetRunner().Cmd(fmt.Sprintf("%s apply -f %s", kubectlcmd, coreDNSSVCPatchFilePath), false, true)
if err != nil {
return errors.Wrap(errors.WithStack(err), fmt.Sprintf("failed to patch coredns service", err))
return errors.Wrap(errors.WithStack(err), "failed to patch coredns service")
}
return nil
}
Expand Down
1 change: 1 addition & 0 deletions cli/pkg/phase/cluster/linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ func (l *linuxInstallPhaseBuilder) installTerminus() phase {
&terminus.GetNATGatewayIPModule{},
&terminus.InstallAccountModule{},
&terminus.InstallSettingsModule{},
&terminus.InstallAppGatewayVendorModule{},
&terminus.InstallOsSystemModule{},
&terminus.InstallLauncherModule{},
&terminus.InstallAppsModule{},
Expand Down
1 change: 1 addition & 0 deletions cli/pkg/phase/cluster/macos.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ func (m *macosInstallPhaseBuilder) installTerminus() phase {
&terminus.GetNATGatewayIPModule{},
&terminus.InstallAccountModule{},
&terminus.InstallSettingsModule{},
&terminus.InstallAppGatewayVendorModule{},
&terminus.InstallOsSystemModule{},
&terminus.InstallLauncherModule{},
&terminus.InstallAppsModule{},
Expand Down
Loading