Repository navigation
Fix overlapping PDF navigation and clipped note controls - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiding Library navigation placed the floating Show nav control over the annotation inspector’s close button. Right-edge PDF notes also extended beyond the page and clipped their close control. Keep the inspector below Show nav on tablet and desktop, clamp note cards using their rendered width, and reserve enough height for the close target. Phone inspector placement stays intact.
Added six browser regression cases for desktop, tablet, and phone layouts, and updated the feature specs.
Validation: full native
npm run ci:localpassed on a clean run (107 browser tests); pre-push affected checks passed (178 unit tests), Fallow reported no introduced findings, and affected mutation scored 73.10%. Visually checked dark tablet and light phone layouts. An unrelated passage-anchor test initially failed, then passed three isolated retries and the clean full run.