Repository navigation
Fix multi-page annotated PDF exports and range responses - #29
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
kirjolab | d979b1c | Nov 13 2026, 12:08 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotated PDF exports could lose later pages and fonts when an old compressed object stream appeared after the PDF's current definitions. Resolve the authoritative cross-reference revisions before editing, preserve active compressed objects and supported indirect page-tree values, and reject ambiguous input before publishing a copy. Bound structural decoding and metadata traversal. Also fix R2 range responses whose undefined suffix property produced NaN Content-Range headers.
Regression coverage uses synthetic multi-page PDFs with incremental, stream, hybrid, and obsolete-object references. PDF.js independently checks every page's text/font and a final-page note. Real Workers and browser tests check exact ranges, unchanged originals, immutable shares, revocation, and failure before publication. The original reported 20-page document was compared locally: every page's text/font and rendered pixels match after export; no private paper is committed.
Validation: full native npm run ci:local, targeted regression tests, and pre-push readability/mutation gates. ADR-250 and the feature contracts document the normalization boundary and its limits. Existing shared copies remain immutable; owners create a new copy to distribute a corrected export.