Repository navigation
Share annotated PDF copies by link and save notes with Cmd/Ctrl+Enter - #28
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
kirjolab | c78d1c5 | Nov 13 2026, 09:57 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers currently need to export an annotated PDF and upload it elsewhere to share feedback. Adds More PDF actions → Share annotated copy, which creates a fixed PDF snapshot that recipients can read or download without signing in. Owners can recover and revoke links; later private annotations do not change existing copies.
Adds Cmd+Enter / Ctrl+Enter to save PDF page notes and highlight comments, preserving multiline notes, validation, and pending-save guards.
Reuses the existing PAPERS bucket and ReferenceLibrary with SQLite migration 21. Annotation reads are bounded and scoped to the selected PDF. Revocation and permanent source deletion retain retryable storage cleanup. Also fixes full PDF downloads incorrectly returning 206 without a Range request. Specs and ADR 249 document the contracts.
Validation: full native
npm run ci:local, affected mutation testing, and desktop/mobile sharing and native PDF preview checks. Expanded unit assertions cover the rendered controls, failure/retry behavior, link boundaries, and anonymous routing.Final local results: 2,883 unit tests, 194 Workers tests, 100 browser tests; affected mutation score 78.00% (required 63%). One collaboration browser test failed during a concurrent run, then passed in isolation and in the full standalone gate without code or timeout changes.