feat: Adds exemplars#54
Open
isaacsanders wants to merge 3 commits into
Open
Conversation
Author
|
I've also use the guidance discussed in this issue to determine how I would expose the option to the user: beam-telemetry/telemetry_metrics#96 |
Author
|
bumping on this. |
Author
|
@bryannaegele Any thoughts on this? |
Open
Collaborator
|
I looked at the docs you listed and looked at the prometheus docs. It seems that exemplars are experimental in prometheus and appears to be an experimental feature flag within a prometheus server. Is that accurate? |
|
@bryannaegele it may be officially listed as "experimental" but major players in the ecosystem do support them. Grafana for example supports both displaying and querying exemplars as well as ingesting them thru their hosted Prometheus offering. My team is considering using this library and would greatly benefit from exemplar support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first draft of an implementation for exposing exemplars.
I used the following documentation to implement exemplars that consist of labels, a value, and a timestamp: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#exemplars