Skip to content

feat: Adds exemplars#54

Open
isaacsanders wants to merge 3 commits into
beam-telemetry:mainfrom
isaacsanders:feat/adds-exemplars
Open

feat: Adds exemplars#54
isaacsanders wants to merge 3 commits into
beam-telemetry:mainfrom
isaacsanders:feat/adds-exemplars

Conversation

@isaacsanders
Copy link
Copy Markdown

This is a first draft of an implementation for exposing exemplars.

I used the following documentation to implement exemplars that consist of labels, a value, and a timestamp: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#exemplars

@isaacsanders
Copy link
Copy Markdown
Author

I've also use the guidance discussed in this issue to determine how I would expose the option to the user: beam-telemetry/telemetry_metrics#96

@isaacsanders
Copy link
Copy Markdown
Author

bumping on this.

@isaacsanders
Copy link
Copy Markdown
Author

@bryannaegele Any thoughts on this?

@isaacsanders isaacsanders mentioned this pull request Jan 11, 2024
@bryannaegele
Copy link
Copy Markdown
Collaborator

I looked at the docs you listed and looked at the prometheus docs. It seems that exemplars are experimental in prometheus and appears to be an experimental feature flag within a prometheus server. Is that accurate?

@weaversam8
Copy link
Copy Markdown

@bryannaegele it may be officially listed as "experimental" but major players in the ecosystem do support them. Grafana for example supports both displaying and querying exemplars as well as ingesting them thru their hosted Prometheus offering.

My team is considering using this library and would greatly benefit from exemplar support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants