Skip to content

Make atoms and string keys the same in aggregator #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MikaAK wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make atoms and string keys the same in aggregator #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/core/aggregator.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ defmodule TelemetryMetricsPrometheus.Core.Aggregator do
end

@spec get_aggregation(key :: key(), table :: atom()) :: {} | aggregation()
defp get_aggregation(key, table) when is_atom(key) do
get_aggregation(to_string(key), table)
end

defp get_aggregation(key, table) do
case :ets.lookup(table, key) do
[] -> {}
Expand All @@ -96,6 +100,10 @@ defmodule TelemetryMetricsPrometheus.Core.Aggregator do
@spec put_aggregation(aggregation :: nil | aggregation(), key :: key(), table :: atom()) :: true
def put_aggregation(nil, _, _), do: true

def put_aggregation(aggregation, key, tid) when is_atom(key) do
put_aggregation(aggregation, to_string(key), tid)
end

def put_aggregation(aggregation, key, tid) do
:ets.insert(tid, {key, aggregation})
end
Expand Down