fix: auto-wrap non-composable additionalInstructions in prepareForPer…

[fichiokaku]

…missions

Since the smart-sessions revamp (#181), prepareInstallSmartSessions emits composable instructions, while additionalInstructions passed in raw { chainId, calls } form (the supported shape in v1.1.x) are non-composable. buildBatch rejects mixed batches with:

"All the instructions must be built with buildComposable in order
to support the runtime time parameters."

Auto-wrap any non-composable resolved instructions as composable rawCalldata instructions when the batch contains composable ones, restoring the v1.1.x calling convention.

---

PR-Codex overview

This PR focuses on enhancing the prepareForPermissions function by introducing a new utility function, normalizeInstructionComposability, which ensures that all instructions in a batch are composable, thereby improving compatibility with previous versions.

Detailed summary

• Added normalizeInstructionComposability function to enforce composability of instructions.
• Updated resolvedInstructions to use normalizeInstructionComposability.
• Implemented logic to wrap non-composable instructions as composable rawCalldata instructions.
• Added comments for clarity on handling native-token transfers and composability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[github-actions]

size-limit report 📦

Path	Size
core (esm)	71.6 KB (+0.24% 🔺)
core (cjs)	86.66 KB (+0.18% 🔺)
bundler (tree-shaking)	7 KB (0%)
paymaster (tree-shaking)	543 B (0%)

[vr16x]

Hey @fichiokaku

Good catch on this, but why not change the calls directly from AbstractCall[] to ComposableCall[]?

So any additional calls must be composable, and this is a strict type-safe behaviour rather than runtime conversions. There is no scope for having a non-composable call here, given the recent change. So this conversion is unnecessary

[vr16x]

Haven't reviewed the code, but suggested a high level directional change