Add first class cuda-compile action#668
Open
keith wants to merge 1 commit into
Open
Conversation
This splits off `cuda-compile` from the `c++-compile` action (behind a incompatible flag) which allows toolchain maintainers to customize cuda compiles separately from normal C++ compiles. This is useful for passing the many cuda specific compiler flags.
keith
requested review from
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
Member
Author
|
this is paired with bazelbuild/bazel#29116 but there is no merge order issue since it's off by default |
lilygorsheneva
added
the
External discussion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits off
cuda-compilefrom thec++-compileaction (behind aincompatible flag) which allows toolchain maintainers to customize cuda
compiles separately from normal C++ compiles. This is useful for passing
the many cuda specific compiler flags.