Remove use_module_maps from layering_check#657
Open
keith wants to merge 1 commit into
Open
Conversation
keith
requested review from
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
armandomontanez
added
type: feature request
| feature_name = "module_maps", | ||
| ) | ||
|
|
||
| cc_feature( |
Collaborator
There was a problem hiding this comment.
This is breaking (the comment above asked users to add this feature to their toolchain configuration). We can work around this by leaving a vacant stub cc_feature in place.
# This is no longer necessary, and does nothing. It will be
# removed in a future release.
cc_feature(
name = "use_module_maps",
feature_name = "use_module_maps",
)
Member
Author
There was a problem hiding this comment.
hrm given how new all this stuff is i kinda think we should just not worry about it. but i guess there's minor risk that someone removes it and then is used with an old rules_cc version that requires it. less of an issue in a post bzlmod world. i added the empty one
keith
force-pushed
the
ks/remove-use_module_maps-from-layering_check
branch
from
763c252 to
419a9e1
Compare
In today's unix toolchain this feature is used to allow adding extra compiler flags, otherwise it is not special. This simplifies what users have to do to setup layering_check. If users want the same custom compiler flags they can add another cc_args that is dependent on the layering_check feature.
keith
force-pushed
the
ks/remove-use_module_maps-from-layering_check
branch
from
419a9e1 to
ebc52d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In today's unix toolchain this feature is used to allow adding extra
compiler flags, otherwise it is not special. This simplifies what users
have to do to setup layering_check. If users want the same custom
compiler flags they can add another cc_args that is dependent on the
layering_check feature.