Skip to content

Clamp uniform quantiles monotonically - #539

Merged
oschulz merged 1 commit into
mainfrom
fix-538-uniform-endpoint-clipping
Sep 1, 2026
Merged

Clamp uniform quantiles monotonically#539
oschulz merged 1 commit into
mainfrom
fix-538-uniform-endpoint-clipping

Conversation

@BJMCox

@BJMCox BJMCox commented Aug 16, 2026

Copy link
Copy Markdown
Member

Fixes #538.

Clamp StandardUvUniform inputs to the input type's floating-point interval [eps(R), 1 - eps(R)] before inverse-CDF evaluation. This keeps infinite-support quantiles finite and preserves monotonicity without coupling the transform to an AD package.

Main code: +4/-4.

@BJMCox BJMCox self-assigned this Aug 16, 2026
@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.43%. Comparing base (b516b29) to head (c077ca0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   65.45%   65.43%   -0.02%     
==========================================
  Files         121      121              
  Lines        7060     7060              
==========================================
- Hits         4621     4620       -1     
- Misses       2439     2440       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BJMCox
BJMCox marked this pull request as ready for review August 16, 2026 09:13
@BJMCox
BJMCox force-pushed the fix-538-uniform-endpoint-clipping branch 3 times, most recently from 5ee16be to 60c2216 Compare September 1, 2026 13:20
@BJMCox BJMCox changed the title Clip only exact uniform endpoints Clamp uniform quantiles monotonically Sep 1, 2026
@BJMCox
BJMCox force-pushed the fix-538-uniform-endpoint-clipping branch 2 times, most recently from fe10148 to 92de65e Compare September 1, 2026 13:38
@BJMCox
BJMCox force-pushed the fix-538-uniform-endpoint-clipping branch from 92de65e to c077ca0 Compare September 1, 2026 17:00
@oschulz
oschulz merged commit 313f5bd into main Sep 1, 2026
27 of 31 checks passed
@BJMCox
BJMCox deleted the fix-538-uniform-endpoint-clipping branch September 4, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clip only exact unit-interval endpoints

2 participants