ci(benchmark): fix engine asset pattern casing (baseRT→basert) - #15
Merged
Merged
Conversation
Release assets are published as basert-engine-macos-arm64-<ver>.tar.gz (lowercase, post-rebrand) but the Benchmark workflow still grepped for baseRT-engine-macos-arm64*.tar.gz — so 'Fetch engine release' failed with 'no assets match the file pattern'. Match the actual asset name.
prabod
added a commit
that referenced
this pull request
Jul 17, 2026
Same casing fix as #15 applied to ci.yml: the Fetch engine step matched nothing since the rebrand, so the engine-linked ABI tests were silently skipped. With the pattern fixed the rust-sys ABI check runs against the latest engine release — it will fail on this PR until the 0.1.6 engine is published, which enforces the intended merge ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Benchmark workflow's Fetch engine release step failed with
no assets match the file pattern.Cause: release assets are published as
basert-engine-macos-arm64-<ver>.tar.gz(lowercase, post-rebrand), but the workflow still grepped forbaseRT-engine-macos-arm64*.tar.gz(camelCase).Fix: match the actual asset name on both the
gh release download --patternand thetar -xzfglob.Verified against
v0.1.4assets:basert-engine-macos-arm64-0.1.4.tar.gz(+.sha256).