Skip to content

Fix potentially uninitialized locals #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hiradary wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix potentially uninitialized locals #2885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/views/prompts/commands/_command.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<% command, description, editor_version = command %>
<% command_name, description, editor_version = prompt_command %>

<lexxy-prompt-item search="<%= description %> <%= command %>">
<lexxy-prompt-item search="<%= description %> <%= command_name %>">
<template type="menu">
<code><%= command %></code> <%= description %>
<code><%= command_name %></code> <%= description %>
</template>
<template type="editor">
<%= editor_version.gsub(/ +$/, "&nbsp;").html_safe %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/prompts/commands/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<%= render partial: "prompts/commands/command", collection: @commands %>
<%= render partial: "prompts/commands/command", collection: @commands, as: :prompt_command %>
16 changes: 12 additions & 4 deletions test/models/account/data_transfer/action_text/rich_text_record_set_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,16 +167,24 @@ class Account::DataTransfer::ActionText::RichTextRecordSetTest < ActiveSupport::

private
def with_default_url_host(host)
options = nil
had_key = false
original = nil
changed_host = false

options = Rails.application.routes.default_url_options
had_key = options.key?(:host)
original = options[:host]
options[:host] = host
changed_host = true
yield
ensure
if had_key
options[:host] = original
else
options.delete(:host)
if changed_host
if had_key
options[:host] = original
else
options.delete(:host)
end
end
end
end
Loading