Add since/until date filtering to activities endpoint#2873
Open
AntonioObra wants to merge 2 commits intobasecamp:mainfrom
Open
Add since/until date filtering to activities endpoint#2873AntonioObra wants to merge 2 commits intobasecamp:mainfrom
AntonioObra wants to merge 2 commits intobasecamp:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds date-range filtering to the activities feed so API clients can request a subset of events by created_at using since/until.
Changes:
- Add
since_date/until_datescopes toEventand apply them inActivitiesController#index. - Document new
sinceanduntilquery parameters forGET /:account_slug/activities. - Add controller tests covering basic date filtering scenarios.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| app/controllers/activities_controller.rb | Applies since/until filters to the activities relation. |
| app/models/event.rb | Introduces since_date / until_date scopes for created_at filtering. |
| docs/api/sections/activities.md | Documents the new query params and expected format. |
| test/controllers/activities_controller_test.rb | Adds tests for since, until, and combined filtering. |
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
sinceanduntilquery parameters to theGET /:account_slug/activitiesendpoint so API clients can filter the activity feed by date range.Requested in #2832.
Changes
app/controllers/activities_controller.rb- filter activities by since and until paramsapp/models/event.rb- add since_date and until_date scopes to Eventdocs/api/sections/activities.md- document the new query parameterstest/controllers/activities_controller_test.rb- add controller tests for date filteringUsage
GET /:account_slug/activities?since=2026-04-01GET /:account_slug/activities?until=2026-04-21GET /:account_slug/activities?since=2026-04-01&until=2026-04-21Dates are ISO 8601 (YYYY-MM-DD)