Skip to content

Return updated comment on PUT /cards/:n/comments/:id #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robzolkos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return updated comment on PUT /cards/:n/comments/:id #2852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/cards/comments_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def update

respond_to do |format|
format.turbo_stream
format.json { head :no_content }
format.json { render :show }
end
end

Expand Down
9 changes: 9 additions & 0 deletions test/controllers/cards/comments_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ class Cards::CommentsControllerTest < ActionDispatch::IntegrationTest

assert_response :success
assert_equal "Flat update", comment.reload.body.to_plain_text

json = @response.parsed_body
assert_equal comment.id, json["id"]
assert_equal "Flat update", json["body"]["plain_text"]
end

test "update as JSON" do
Expand All @@ -111,6 +115,11 @@ class Cards::CommentsControllerTest < ActionDispatch::IntegrationTest

assert_response :success
assert_equal "Updated comment", comment.reload.body.to_plain_text

json = @response.parsed_body
assert_equal comment.id, json["id"]
assert_equal "Updated comment", json["body"]["plain_text"]
assert_equal comment.creator.id, json["creator"]["id"]
end

test "edit a comment that contains a mention" do
Expand Down
Loading