Skip to content

Add direct-push alerting and sensitive-change gate#12

Merged
jeremy merged 1 commit intomainfrom
phase4-alerts
Mar 8, 2026
Merged

Add direct-push alerting and sensitive-change gate#12
jeremy merged 1 commit intomainfrom
phase4-alerts

Conversation

@jeremy
Copy link
Copy Markdown
Member

@jeremy jeremy commented Mar 8, 2026

Summary

  • direct-push-alert: Detects commits pushed directly to the default branch (bypassing PR flow) and creates/appends to a tracking issue.
  • sensitive-change-gate: Detects PR changes to control-plane paths (workflows, CODEOWNERS, .goreleaser.yaml, release scripts). Runs in shadow mode — posts an informational comment but does not block.

Both are thin callers to reusable workflows in basecamp/.github, pinned to SHA a667bfaa.

Test plan

  • Open a PR touching .github/workflows/ — verify shadow comment appears

Copilot AI review requested due to automatic review settings March 8, 2026 20:42
@jeremy jeremy requested a review from a team as a code owner March 8, 2026 20:42
@github-actions github-actions Bot added the ci label Mar 8, 2026
@jeremy jeremy enabled auto-merge (squash) March 8, 2026 20:43
@jeremy jeremy merged commit eb050dc into main Mar 8, 2026
22 checks passed
@jeremy jeremy deleted the phase4-alerts branch March 8, 2026 20:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two new GitHub Actions workflows that serve as thin callers to reusable workflows hosted in basecamp/.github, both pinned to a specific SHA (a667bfaa):

Changes:

  • Adds direct-push-alert.yml to detect commits pushed directly to main (bypassing PR flow) and create/append to a tracking issue.
  • Adds sensitive-change-gate.yml to detect PR changes to control-plane paths (workflows, CODEOWNERS, etc.), running in shadow mode with an informational comment. Includes scripts/sync-skills.sh as an extra sensitive pattern.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/direct-push-alert.yml New workflow triggered on push to main, calling the reusable direct-push-alert workflow with contents: read and issues: write permissions
.github/workflows/sensitive-change-gate.yml New workflow triggered on pull_request_target, calling the reusable sensitive-change-gate workflow with an extra pattern for scripts/sync-skills.sh

Both workflows follow the established repository conventions for reusable workflow calls (SHA pinning, job-level permissions, pull_request_target for PR-scoped workflows), consistent with the existing ai-labeler.yml pattern.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants