Skip to content

Refactor localStorageFS to bridgeFS#36

Open
snelusha wants to merge 2 commits intoballerina-platform:mainfrom
snelusha:refactor/bridge-fs
Open

Refactor localStorageFS to bridgeFS#36
snelusha wants to merge 2 commits intoballerina-platform:mainfrom
snelusha:refactor/bridge-fs

Conversation

@snelusha
Copy link
Copy Markdown
Contributor

@snelusha snelusha commented Apr 16, 2026

Purpose

$subject

This pull request refactors the WASM filesystem abstraction by replacing the previous localStorage-backed implementation with a new bridge-backed implementation and updates related dependency versions.

Changes

  • Core refactor (packages/wasm):

    • Replaced the localStorageFS implementation with bridgeFS: renamed the concrete FS type and all associated file handle, file info, and directory entry types from localStorage* to bridge* variants.
    • Updated the exported constructor from NewLocalStorageFS to NewBridgeFS and updated callers (packages/wasm/main_wasm.go) to instantiate the new implementation.
    • Removed the //go:build wasm build constraint from the implementation file.
    • All filesystem operations and error-mapping logic were preserved while switching receivers and type names to the bridge* variants.
  • Dependency updates:

    • apps/web/package.json: bumped several runtime and dev dependencies (including React, react-dom, TanStack Router, CodeMirror packages, tailwind/shadcn tooling, zustand, TypeScript, Vite, and related packages).
    • Root package.json: updated devDependencies (@biomejs/biome, turbo).

Impact

  • Functional behavior of filesystem operations is intended to remain equivalent; the change clarifies and broadens the filesystem abstraction to make it easier to support multiple storage backends going forward.
  • Dependency bumps update runtime and tooling versions across the web app and root workspace.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

Warning

Rate limit exceeded

@snelusha has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 48 minutes and 18 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 48 minutes and 18 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f07fecf3-b986-4ded-95f6-f165eb518686

📥 Commits

Reviewing files that changed from the base of the PR and between ae1873f and 596d7bd.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • apps/web/package.json
  • package.json
📝 Walkthrough

Walkthrough

Bumped dependency and devDependency version specifiers in root and apps/web package.json files. Refactored WASM filesystem implementation: removed the //go:build wasm constraint, renamed localStorageFS to bridgeFS (types, methods, constructor NewLocalStorageFSNewBridgeFS), and updated call sites accordingly.

Changes

Cohort / File(s) Summary
Dependency version updates
apps/web/package.json, package.json
Updated runtime and dev dependency version specifiers (notable: React/react-dom, @tanstack/react-router/router-plugin, tailwind/shadcn, zustand, @biomejs/biome, turbo, typescript, vite, @types/node, globals). No code or API changes beyond versions.
WASM filesystem rename & build tag removal
packages/wasm/bridge_fs_wasm.go, packages/wasm/main_wasm.go
Removed //go:build wasm from the WASM file, renamed concrete FS and related types from localStorage* to bridge*, changed constructor NewLocalStorageFSNewBridgeFS, and updated main_wasm.go to instantiate NewBridgeFS. Logic and proxy/error mappings preserved.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • warunalakshitha

Poem

🐰 I hopped across code, soft and swift,
A bridge was born where storage lived,
Versions climbed like springtime trees,
Types renamed with gentle ease,
I nibble bugs and leave a gift. 🥕✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is severely incomplete, containing only a placeholder '$subject' in the Purpose section with no other required sections populated. Complete the description by filling in all required sections from the template: Goals, Approach, User stories, Release note, Documentation, Training, Certification, Marketing, Automation tests, Security checks, Samples, Related PRs, Migrations, Test environment, and Learning.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the primary refactoring work: renaming localStorageFS to bridgeFS across the codebase.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant