Skip to content

Part of #1133: clear mypy side-findings#1211

Closed
axisrow wants to merge 0 commit into
mainfrom
ao/tg_content_factory_5863f66be3-21/chore/1133-mypy-sidefindings
Closed

Part of #1133: clear mypy side-findings#1211
axisrow wants to merge 0 commit into
mainfrom
ao/tg_content_factory_5863f66be3-21/chore/1133-mypy-sidefindings

Conversation

@axisrow

@axisrow axisrow commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Part of #1133.

Summary

Mypy delta

Check Before After
python -m mypy src/ 384 errors 365 errors
Exact 8 target file:line reports 8 0
Normalized new errors n/a 0

The total drop is larger than 8 because the settings guard and photo/bootstrap narrowings also remove adjacent pre-existing reports in the same guarded blocks. Point 7 stayed in this PR; it did not trigger a new-error cascade.

Validation

  • ruff check src/ tests/ conftest.py — passed.
  • python -c "import src.services.agent_provider_service" — passed.
  • python -c "import src.telegram.pool_lifecycle" — passed.
  • pytest tests/test_production_limits_service.py tests/test_cli_extended.py tests/test_deepagents_sync_provider_paths.py::TestProviderConfigServiceLoadModelCache tests/test_deepagents_sync_provider_paths.py::TestProviderConfigServiceCompatibility -q — 74 passed.
  • pytest tests/routes/test_settings_routes.py tests/routes/test_settings_routes_provider_notifications.py tests/routes/test_photo_loader_routes.py tests/test_bootstrap.py tests/routes/test_accounts_agent_web_mode.py tests/test_web_runtime_shims.py -q — 185 passed.
  • pytest tests/test_client_pool_lifecycle.py tests/test_mtproto_watchdog.py tests/test_dialog_cache_ttl.py -q — 41 passed.
  • pytest tests/ -k "(provider or pool or bootstrap or photo_loader or production_limits) and not quality" -x -q — 1734 passed, 26 skipped.

Known pre-existing validation note: the exact required broad command pytest tests/ -k "provider or pool or bootstrap or photo_loader or production_limits" -x -q stops on tests/test_quality_scoring_service.py::test_score_content_uses_default_provider. I reproduced the same failure from a clean origin/main worktree at commit 4555c52, so it is not introduced by this branch.

@axisrow axisrow closed this Jun 30, 2026
@axisrow axisrow force-pushed the ao/tg_content_factory_5863f66be3-21/chore/1133-mypy-sidefindings branch from ea7dc7f to 49cdaa3 Compare June 30, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant