Part of #1133: clear mypy side-findings#1211
Closed
axisrow wants to merge 0 commit into
Closed
Conversation
ea7dc7f to
49cdaa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1133.
Summary
# type: ignoreand without touching CI.TYPE_CHECKING-only service casts for provider mixin host access and local narrowing forpool_lifecycle/SnapshotCollectorpaths.Mypy delta
python -m mypy src/The total drop is larger than 8 because the settings guard and photo/bootstrap narrowings also remove adjacent pre-existing reports in the same guarded blocks. Point 7 stayed in this PR; it did not trigger a new-error cascade.
Validation
ruff check src/ tests/ conftest.py— passed.python -c "import src.services.agent_provider_service"— passed.python -c "import src.telegram.pool_lifecycle"— passed.pytest tests/test_production_limits_service.py tests/test_cli_extended.py tests/test_deepagents_sync_provider_paths.py::TestProviderConfigServiceLoadModelCache tests/test_deepagents_sync_provider_paths.py::TestProviderConfigServiceCompatibility -q— 74 passed.pytest tests/routes/test_settings_routes.py tests/routes/test_settings_routes_provider_notifications.py tests/routes/test_photo_loader_routes.py tests/test_bootstrap.py tests/routes/test_accounts_agent_web_mode.py tests/test_web_runtime_shims.py -q— 185 passed.pytest tests/test_client_pool_lifecycle.py tests/test_mtproto_watchdog.py tests/test_dialog_cache_ttl.py -q— 41 passed.pytest tests/ -k "(provider or pool or bootstrap or photo_loader or production_limits) and not quality" -x -q— 1734 passed, 26 skipped.Known pre-existing validation note: the exact required broad command
pytest tests/ -k "provider or pool or bootstrap or photo_loader or production_limits" -x -qstops ontests/test_quality_scoring_service.py::test_score_content_uses_default_provider. I reproduced the same failure from a cleanorigin/mainworktree at commit4555c52, so it is not introduced by this branch.