Enable MCP server extension for Sherpa#1108
Conversation
|
|
||
| # Copy MCP server config and client settings to user-level Jupyter config | ||
| mkdir -p ~/.jupyter | ||
| cp /etc/sagemaker/jupyter/server/jupyter_server_config.py ~/.jupyter/ |
There was a problem hiding this comment.
jupyter server config I believe can live elsehwere, see https://github.com/aws/sagemaker-distribution/blob/main/template/v4/dirs/etc/sagemaker-ui/jupyter/server/jupyter_server_config.py and https://github.com/aws/sagemaker-distribution/blob/1081fddecb837e8fb9497e62ab186662666bd644/template/v4/dirs/usr/local/bin/start-sagemaker-ui-jupyter-server#L19C1-L19C90
| fi | ||
|
|
||
| # Run SMAI post startup script | ||
| bash /etc/sagemaker/smai_post_startup.sh |
There was a problem hiding this comment.
ok did a bit of digging- seems that the SMUS post startup script is actually triggered separately from extension and that is why it is called "post startup script". let's actually move back to having the commands here directly- my bad.
There was a problem hiding this comment.
I believe in SMUS it is triggered via workflows
- Add jupyter_server_mcp config (jupyter_server_config.py, mcp_settings.json) - Add JupyterLab overrides to place chat panel on right side - Inline MCP config copy commands in start-jupyter-server entrypoint
aws-srijach
force-pushed
the
enable-mcp-main
branch
from
2fe4eb6 to
a30e094
Compare
# Conflicts: # template/v4/Dockerfile
Jupyter AI v3.0 auto-detects jupyter_server_mcp and ships with the notebook toolkit built-in. Remove manual MCP client settings and server config that are no longer needed.
|
General comment: Squash multiple commits into one commit for a CR or merge request. |
@aws-pavankks |
3 participants
Description
This adds the
jupyter-server-mcpextension configurationType of Change
Release Information
Does this change need to be included in patch version releases? By default, any pull requests will only be added to the next SMD image minor version release once they are merged in template folder. Only critical bug fix or security update should be applied to new patch versions of existed image minor versions.
If yes, please explain why:
[Explain the criticality of this change and why it should be included in patch releases]
How Has This Been Tested?
docker buildjupyter_server_mcp0.1.2 loads as enabled server extension (jupyter server extension list)~/.jupyter/at startup viasmai_post_startup.shlocalhost:3001/mcpwith proper MCP protocol initializationChecklist:
Test Screenshots (if applicable):
Related Issues
[Link any related issues here]
Additional Notes
jupyter-server-mcpconda package needs to be added tocpu.env.in/gpu.env.inin the release branch