Adding Net v12 / GIN v13 API Header#1195
Merged
hershys-aws merged 4 commits intoaws:masterfrom Apr 21, 2026
Merged
Conversation
hershys-aws
changed the title
hershys-aws
changed the title
rauteric
reviewed
Apr 16, 2026
anshumang
reviewed
Apr 17, 2026
bwbarrett
previously approved these changes
Apr 17, 2026
hershys-aws
force-pushed
the
gin-v13-api
branch
from
2d8d3d7 to
a47a2e1
Compare
Add net_v12.h header from NCCL v2.30.3-1 containing ncclNet_v12_t, ncclNetProperties_v12_t, ncclNetCommConfig_v12_t, ncclGinConfig_v13_t, ncclGin_v13_t, and supporting types. Include it from net.h. Signed-off-by: Hershel Shah <hershys@amazon.com>
Add net v12 wrappers (init_v12, getProperties_v12, connect_v12) and ncclNetPlugin_v12 export struct. Reuses listen_v11, accept_v9, regMr_v8, finalize_v11, and other existing wrappers where signatures are compatible. Add v12 to the NCCL_NET name fixup constructor. getProperties_v12 fills the new railId and planeId fields with -1. Signed-off-by: Hershel Shah <hershys@amazon.com>
hershys-aws
force-pushed
the
gin-v13-api
branch
from
a47a2e1 to
7d17542
Compare
anshumang
previously approved these changes
Apr 20, 2026
Add v13 GIN API support. createContext passes collComm directly as ginCtx (no wrapper struct needed since all state lives in put_comm). destroyContext is a no-op; lifetime is owned by closeColl. Add v13 wrappers for getProperties (ncclNetProperties_v12_t), iput, and iputSignal which drop the context parameter and delegate to the v11 implementation. ginProgress points directly to the v11 function since the signature is identical. iget and iflush are stubbed as nullptr. Signed-off-by: Hershel Shah <hershys@amazon.com>
Update gin.cpp to exercise the v13 GIN API: load ncclGinPlugin_v13, use ncclNetProperties_v12_t for getProperties, call createContext / destroyContext, and pass ginCtx to iput, iputSignal, and ginProgress. Signed-off-by: Hershel Shah <hershys@amazon.com>
hershys-aws
force-pushed
the
gin-v13-api
branch
from
7d17542 to
4331c3f
Compare
bhasunit
approved these changes
Apr 21, 2026
anshumang
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.