Skip to content

fix: resolve aria-hidden focusable descendants accessibility violation #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LorenzoGalassi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve aria-hidden focusable descendants accessibility violation #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/components/FloatingWhatsApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,10 @@ export function FloatingWhatsApp({
className={`${css.whatsappButton} ${buttonClassName}`}
onClick={handleOpen}
style={buttonStyle}
aria-hidden='true'
role='button'
tabIndex={0}
aria-label='Open WhatsApp chat'
onKeyDown={(e) => e.key === 'Enter' || e.key === ' ' ? handleOpen(e as unknown as React.MouseEvent<HTMLDivElement>) : undefined}
>
<WhatsappSVG />
{isNotification && (
Expand All @@ -226,7 +229,8 @@ export function FloatingWhatsApp({
<div
className={`${css.whatsappChatBox} ${isOpen ? css.open : css.close} ${chatboxClassName}`}
onClick={(event) => event.stopPropagation()}
aria-hidden='true'
aria-hidden={!isOpen}
{...(!isOpen && { inert: '' })}
style={{ height: isOpen ? chatboxHeight : 0, ...chatboxStyle }}
>
<header className={css.chatHeader}>
Expand All @@ -237,7 +241,14 @@ export function FloatingWhatsApp({
<span className={css.statusTitle}>{accountName}</span>
<span className={css.statusSubtitle}>{statusMessage}</span>
</div>
<div className={css.close} onClick={handleClose} aria-hidden='true'>
<div
className={css.close}
onClick={handleClose}
role='button'
tabIndex={0}
aria-label='Close WhatsApp chat'
onKeyDown={(e) => (e.key === 'Enter' || e.key === ' ') && handleClose()}
>
<CloseSVG />
</div>
</header>
Expand Down