sync aria-hidden and disabled input and button with !isOpen for SEO#27
Open
darwinva97 wants to merge 1 commit intoawran5:mainfrom
Open
sync aria-hidden and disabled input and button with !isOpen for SEO#27darwinva97 wants to merge 1 commit intoawran5:mainfrom
darwinva97 wants to merge 1 commit intoawran5:mainfrom
Conversation
|
lgtm |
ShreyMarwaha
approved these changes
Sep 26, 2024
|
Hey @darwinva97 , I’ve created and been actively maintaining a fork under @dxkit-org/react-floating-whatsapp Would love for you to check it out, try it in your projects, and share feedback or ideas for improvements. Contributions are always welcome! 💡✨ |
Author
|
Great! I'll take a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better SEO of the component.
If an element has "aria-hidden" set to true, its children must not be "focusable".
Base of solution:
https://dequeuniversity.com/rules/axe/4.7/aria-hidden-focus