Repository navigation
Port #563 to 4.x: Fix double root issue - #781
Merged
Merged
Conversation
The uploader reads a resizable image from the Curator disk using the temporary file's prefixed path, so a cloud temporary disk with a root (or a different disk from Curator's) can't be read. This test fails until that's fixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Port of awcodes#563. The uploader read resizable images with Storage::disk($curatorDisk)->get($file->path()), but path() already carries the temporary disk's root, so a root of `public` became `public/public/livewire-tmp/...`, and it read from Curator's disk rather than the temporary one. TemporaryUploadedFile::get() reads the file from its own disk with the unprefixed path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #563
I just ran into the same issue I fixed a few years ago. Looks like this never made it to
4.xand5.x.