Skip to content

[tinker] Route uvicorn's access log to a plain handler instead of Rich #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avigyabb wants to merge 1 commit into from
Closed

[tinker] Route uvicorn's access log to a plain handler instead of Rich #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion skyrl/utils/log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,23 @@ def get_uvicorn_log_config() -> dict:
**RICH_HANDLER_KWARGS,
"formatter": "default",
},
# Plain handler for the per-request access log: RichHandler renders
# each record through a rich Table (~1.5ms of event-loop CPU per
# record), which at thousands of requests per second is the API
# server's single largest CPU cost.
"access": {
"class": "logging.StreamHandler",
"formatter": "default",
"stream": "ext://sys.stderr",
},
},
"loggers": {
# Main uvicorn logger (general server messages)
"uvicorn": {"handlers": ["default"], "level": "INFO", "propagate": False},
# Uvicorn error logger (startup, shutdown, exceptions)
"uvicorn.error": {"handlers": ["default"], "level": "INFO", "propagate": False},
# HTTP access logs (request/response logging)
"uvicorn.access": {"handlers": ["default"], "level": "INFO", "propagate": False},
"uvicorn.access": {"handlers": ["access"], "level": "INFO", "propagate": False},
},
}

Expand Down
Loading