ci: bind workflow_dispatch inputs via env before shell - #838
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
Avoid expanding github.event.inputs.* inside run scripts for try-runtime and weights dispatch workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind
github.event.inputs.*into stepenv:before shell use in the try-runtime and weightsworkflow_dispatchworkflows.This follows the common GitHub Actions hardening pattern: keep
${{ }}expressions out ofrun:scripts so values are not subject to unexpected shell interpolation.Test plan
Try Runtime Checks/Run benchmarks for weightswith default inputsMade with Cursor