fix: do not expose settled blocks in an invalid state#258
Merged
StephenButtolph merged 8 commits intomainfrom Mar 3, 2026
Merged
fix: do not expose settled blocks in an invalid state#258StephenButtolph merged 8 commits intomainfrom
StephenButtolph merged 8 commits intomainfrom
Conversation
JonathanOppenheimer
requested review from
ARR4N and
StephenButtolph
as code owners
JonathanOppenheimer
changed the title
JonathanOppenheimer
changed the title
…-labs/strevm into JonathanOppenheimer/fix-get-reciepts
StephenButtolph
approved these changes
Mar 3, 2026
Contributor
|
I'm removing the "bug" label, as this really isn't a bug... It is a potential future bug... Which now doesn't exist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can avoid returning settled blocks in an invalid state by not returning a
*blocks.Blockat all. To do so, we replacegetBlock(which returned a*blocks.Blockin invalid state per its TODO) withgetReceipts, which only returns what callers need:(types.Receipts, *types.Block, error). This means the intermediate*blocks.Blockis constructed internally is never leaked, so our concern is gone.