chain: refactor transaction tests#1748
Open
najeal wants to merge 5 commits intoava-labs:mainfrom
Open
Conversation
aaronbuchwald
requested changes
Nov 20, 2024
Collaborator
aaronbuchwald
left a comment
aaronbuchwald
left a comment
There was a problem hiding this comment.
Nice! Thanks for refactoring this to better share setup code.
Left one comment to use a setup helper function rather than use the testify Suite library
| func (*action2) GetTypeID() uint8 { | ||
| return 222 | ||
| func TestTransactionTestSuite(t *testing.T) { | ||
| suite.Run(t, new(TransactionTestSuite)) |
Collaborator
There was a problem hiding this comment.
I'm not sure testify suite adds much value to the tests beyond what we can do with a single helper function at the start of each test and would prefer not to introduce it here as the only test where we start using this tool.
Could we instead share test setup code via a single setup helper function that returns the fields that have currently been added to TransactionTestSuite ?
Contributor
Author
|
Changes have been applied 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1702 and refactors transaction tests to reduce testing logic to the minimum.
Tests were previously doing the same initialization. It was verbose. It has been moved in the setup of a test suite.