Skip to content

chore: increase fuzz timeout to 5m#5309

Closed
JonathanOppenheimer wants to merge 1 commit intomasterfrom
JonathanOppenheimer/increase-unit-test-timeout
Closed

chore: increase fuzz timeout to 5m#5309
JonathanOppenheimer wants to merge 1 commit intomasterfrom
JonathanOppenheimer/increase-unit-test-timeout

Conversation

@JonathanOppenheimer
Copy link
Copy Markdown
Contributor

Why this should be merged

We want to run fuzz tests in CI, and the current 2m is not enough time for fuzz to run without flaking. 5m seems like ample time, and would not bottleneck CI.

How this works

Changes 120s to 5m

How this was tested

CI

Need to be documented in RELEASES.md?

No

Copilot AI review requested due to automatic review settings April 27, 2026 09:52
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner April 27, 2026 09:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases the default go test timeout used by the repository’s test script to reduce CI flakiness when running fuzz tests.

Changes:

  • Update the default go test timeout in scripts/build_test.sh from 120s to 5m (still overridable via TIMEOUT).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ARR4N
Copy link
Copy Markdown
Contributor

ARR4N commented Apr 27, 2026

It's really weird that this even takes 2 minutes. Locally it takes only 3 seconds to run the whole of go test ./vms/saevm/sae.

@JonathanOppenheimer
Copy link
Copy Markdown
Contributor Author

It's really weird that this even takes 2 minutes. Locally it takes only 3 seconds to run the whole of go test ./vms/saevm/sae.

The average with the runners is about ~80s 🤷.

@alarso16
Copy link
Copy Markdown
Contributor

What you linked isn't a fuzz test. It's a unit test with a subtest called "fuzz". This flake is known and well-understood, which would be addressed by #5292

@JonathanOppenheimer
Copy link
Copy Markdown
Contributor Author

JonathanOppenheimer commented Apr 27, 2026

What you linked isn't a fuzz test. It's a unit test with a subtest called "fuzz". This flake is known and well-understood, which would be addressed by #5292

I was under the impression that increasing the time out for these fuzz subcases tests would fix the flake -- there's no --fuzz in the test build script, and we see the timeout in CI after 2 minutes which is what had currently been set. I will close this in favor of your PR which we should try to merge soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants