Draft
Conversation
alarso16
force-pushed
the
alarso16/gosec-test
branch
from
7023e92 to
2410fe5
Compare
alarso16
force-pushed
the
alarso16/gosec-test
branch
from
2410fe5 to
38cbf10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Specifying each nosec clause in a test file is unnecessary. If something's wrong, the test will probably fail! Most of the time, it's false positives anyway
How this works
Remove gosec checks from tests and all corresponding nolints. I found some other stale nosec's, so I removed them too. Unfortunately, there doesn't seem to be a linter for unnecessary nosec's.
How this was tested
CI passes
Need to be documented in RELEASES.md?
No