Add GPG signing to linux binary tarball builds#5289
Open
Conversation
Add detached GPG signatures (.sig) to the tarball packaging pipeline, reusing the same key infrastructure as RPM signing.
Use a job-scoped temp directory for GNUPGHOME instead of the default ~/.gnupg to avoid mutating shared state on persistent runners. Clean up via trap EXIT so the keyring is removed even on script failure. Pass passphrase via stdin (--passphrase-fd 0) instead of command line to avoid exposure in /proc/<pid>/cmdline.
PlatCore
force-pushed
the
PlatCore/5160-add-signing-linux-binaries
branch
from
7af6acf to
9b6a785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Linux binary tarballs are uploaded to S3 unsigned. RPM packages already have GPG signing. This adds detached signatures (
.tar.gz.sig) to close that gap.Closes #5160
How this works
build-tgz-pkg.sh: imports GPG key into tempGNUPGHOME, signs each tarball withgpg --detach-sign, verifies inline, uploads.sigto S3. No-op when no key is provided.build-linux-binaries.yml: both jobs import GPG key fromRPM_GPG_PRIVATE_KEYsecret, pass it to the script, and include.sigin artifacts.How this was tested
.sigfiles produced,gpg --verifypasses~/.gnupgnever touched (tempGNUPGHOMEisolation verified)Need to be documented in RELEASES.md?
No