test: support debug_getRaw* RPCs#5284
Merged
StephenButtolph merged 16 commits intomasterfrom Apr 30, 2026
Merged
Conversation
In `TestGetReceipts` - new entries in the test table covering previously untested lookup paths: - `debug_getRawReceipts` (and `eth_getBlockReceipts`) by explicit block number for on-disk, settled, and unsettled blocks - previously only tested by hash. - `debug_getRawReceipts` (and `eth_getBlockReceipts`) for `SafeBlockNumber` and `FinalizedBlockNumber` - previously only `LatestBlockNumber` was covered. Signed-off-by: Tsvetan Dimitrov (tsvetan.dimitrov@avalabs.org)
JonathanOppenheimer
requested review from
ARR4N and
StephenButtolph
as code owners
JonathanOppenheimer
changed the title
debug_getRaw* RPCs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands SAE’s JSON-RPC test suite to cover the remaining debug_getRaw* methods (block/header/receipts/transaction) and adds coverage for debug_printBlock, now that the underlying receipt and block lookup paths are implemented.
Changes:
- Add new RPC tests for mempool raw transaction retrieval (
eth_getRawTransactionByHash,debug_getRawTransaction). - Extend existing block/receipt getter tests to validate
debug_getRawBlock,debug_getRawHeader, anddebug_getRawReceiptsoutputs (RLP / raw encodings). - Update debug RPC integration tests to include
debug_printBlock, and refresh the debug namespace comment list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
vms/saevm/sae/rpc_test.go |
Adds/extends RPC tests to cover debug raw getters for blocks, headers, receipts, and transactions (including mempool). |
vms/saevm/sae/rpc/server.go |
Updates the inline documentation list of debug RPC methods exposed when DB inspecting is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JonathanOppenheimer
restored the
JonathanOppenheimer/test-debug-raw-rpcs
branch
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Contributor
Author
|
See ava-labs/strevm#257 for a number of comments in the original PR. |
alarso16
reviewed
Apr 15, 2026
alarso16
approved these changes
Apr 15, 2026
powerslider
approved these changes
Apr 27, 2026
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/test-debug-raw-rpcs
branch
from
67a3d15 to
9c03f8b
Compare
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
StephenButtolph
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR adds test coverage for the remaining
debug_getRaw*RPC methods, now thatBlockByNumberOrHashandGetReceiptshave been implemented. I also added coverage fordebug_printBlockas it seems this was mistakenly added to the list without being tested.How this works
Self-explanatory.
How this was tested
CI
Need to be documented in RELEASES.md?
No