Initial transitionvm PoC#5222
Closed
StephenButtolph wants to merge 12 commits intoceyonur/sae-warpfrom
Closed
Conversation
Contributor
Author
|
See: #5303 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This shouldn't be merged, it is intended as an MVP to build on.
How this works
This introduces an (almost) VM agnostic transition VM that wraps two VM interfaces and remaps everything from the first VM to the second VM after the transition block is accepted.
Remaining TODOs:
CheckInvariantson the blocks).BuildBlockto be called in SAE withoutSetPreferencehaving been called. It should default to the LastAcceptedBlock.How this was tested
Need to be documented in RELEASES.md?