tests: pin generation order of invalid-ER fraud proofs (#1892)#3794
Merged
tests: pin generation order of invalid-ER fraud proofs (#1892)#3794
Conversation
386a3be to
358aae7
Compare
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds six integration tests in
domains/client/domain-operator/src/tests.rsthat pin the priority order of
DomainBlockProcessor::generate_fraud_proof().Each test corrupts a single ER in the priority-N field plus everything
below it on the same receipt, submits the malicious bundle, and asserts
the matching
FraudProofVariantfires — confirming higher-prioritymismatches win when multiple fields are simultaneously bad.
Existing single-field FP tests cover each variant in isolation; this PR
fills the only remaining gap (ordering when multiple fields are wrong).
Closes #1892.
I recommend reviewing commit-by-commit
Code contributor checklist: