Skip to content

tests: pin generation order of invalid-ER fraud proofs (#1892)#3794

Merged
vedhavyas merged 8 commits intomainfrom
tests/fp-ordering-1892
May 1, 2026
Merged

tests: pin generation order of invalid-ER fraud proofs (#1892)#3794
vedhavyas merged 8 commits intomainfrom
tests/fp-ordering-1892

Conversation

@vedhavyas
Copy link
Copy Markdown
Contributor

@vedhavyas vedhavyas commented Apr 30, 2026

Summary

Adds six integration tests in domains/client/domain-operator/src/tests.rs
that pin the priority order of DomainBlockProcessor::generate_fraud_proof().
Each test corrupts a single ER in the priority-N field plus everything
below it on the same receipt, submits the malicious bundle, and asserts
the matching FraudProofVariant fires — confirming higher-priority
mismatches win when multiple fields are simultaneously bad.

Existing single-field FP tests cover each variant in isolation; this PR
fills the only remaining gap (ordering when multiple fields are wrong).

Closes #1892.

I recommend reviewing commit-by-commit

Code contributor checklist:

@vedhavyas vedhavyas force-pushed the tests/fp-ordering-1892 branch from 386a3be to 358aae7 Compare April 30, 2026 12:38
@vedhavyas vedhavyas marked this pull request as ready for review April 30, 2026 14:08
@immunefi-magnus
Copy link
Copy Markdown

🛡️ Immunefi PR Reviews

We noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below:

🔗 Send this PR in for review

Once submitted, we'll take care of assigning a reviewer and follow up here.

@vedhavyas vedhavyas merged commit 3ede612 into main May 1, 2026
15 checks passed
@vedhavyas vedhavyas deleted the tests/fp-ordering-1892 branch May 1, 2026 07:44
@vedhavyas vedhavyas mentioned this pull request May 1, 2026
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests that ensure a strict order for the Invalid ER fraud proof

1 participant