[AUT-3290] Remove verbose device integrity error log#74
Draft
stevenclouston wants to merge 11 commits intomainfrom
Draft
[AUT-3290] Remove verbose device integrity error log#74stevenclouston wants to merge 11 commits intomainfrom
stevenclouston wants to merge 11 commits intomainfrom
Conversation
Remove AppAttestationProvider enum from public API. The provider is now hardcoded as "APP_ATTEST" in the request since iOS only ever uses App Attest. Public AppAttestation struct now just takes token and optional keyId. Also bumps version to 2.4.0-alpha.2.
Instead of requiring callers to generate the App Attest attestation externally and pass it in, the SDK now generates it internally using the correct nonce format (tenantID:publicKey) when appAttestation is provided as a signal to enable attestation.
Avoids confusion with the Authsignal JWT token used elsewhere in the SDK.
Change appAttestation param from AppAttestation? to Bool. When true, the SDK generates the attestation using the idempotencyKey from the JWT token as the nonce instead of requiring the caller to provide it.
…-app-attestation-to-device-integrity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Logger.errorthat exposed App Attest failure detailsTest plan