Improve flatpak metainfo for quality guidelines

[Beryesa]

Shorter description (<35)
Screenshots with native decorations and shadows
Link to vcs-browser

[Beryesa]

Sidenote: the app icon in the native titlebar seems to be broken upstream? electron/electron#49285

[Beryesa]

Regarding quality-guidelines#just-the-name and quality-guidelines#no-trademark-violations,

The app name is technically "Penpot Desktop" (not Penpot itself) and it is embraced unofficially in https://penpot.app/self-host#options (under Desktop app) & https://community.penpot.app/t/faq-is-there-a-desktop-app-option-for-penpot/2038; but should we still ask for an explicit permission, and then maybe change the displayed app name to Penpot? @bbhtt

[Belar]

Hi, the changes look good.

If we need to do anything about the name, I can check what options are available, but we may need some distinction that it’s its own project.

[Beryesa]

After asking in the Matrix room, it seems that we can/will keep the Flatpak ID as it is, even if we rename the metainfo. So, I suggest we merge this before the next release. Then, once we have only the "Just the name" check left, we can continue from there.

[Beryesa]

As for the broken window icon, it seems to be fixed and backported electron/electron@2dc82ea - I can quickly update the screenshots if we could bump the electron version to v39.3.0+ or v40.1.0+ before merging this #268

[Belar]

Thanks for looking into it. If we change the “display name” (in the meta info), the distinction to the Penpot project will still blur, even if the ID remains. If we can go without the name change, I agree, let’s get these fixes in and cross that bridge when we get there.

I upgraded Electron and will merge this PR when you are ready.

[Beryesa]

Hmm interesting, I rebuilt it from the latest commit, and it generated sources for v40.2.1 which should include the fix electron/electron@1c2b4e0 but it didn't help; keeping the new screenshots as is for now.

Also built the appimage to see if it was the sandbox but nope

[Belar]

It may be set incorrectly or not at all. I recall the “magical” global properties that I need to investigate, but so far it's not an issue. It looks like a good opportunity to look into it; will do.

[Belar]

I looked into the window icon. Using Fedora 43, with KDE Plasma (Wayland), the most recent release (v0.23.0, electron@39.2.7) installed through RPM package has the icon as expected. Seems like the global.AppIcon is unused, always undefined, and the build falls back to the executable’s icon as it should.

The situation is different with Flatpak and AppImage. Themselves they don’t have the icon (tried multiple ways of setting it, with the latest Electron version), however, with installation alongside RPM (multiple versions simultaneously), the other methods will have the icon. With that, I’m not sure if it’s the Electron-Wayland issue or rather a packaging problem. Interestingly, the menu bar icon is working for all installations.

[Belar]

@Beryesa I’m preparing a patch release - a small maintenance update. Would you like to get this one in, or rather wait for a resolution to the icon issue?
I didn’t have time to look into the icon, only recently checked how Electron Fiddle fares there (an official application) and found it has similar problems.

[Beryesa]

This one is functionally insignificant, just some metadata after all. I'd say we can fix the bigger (but still insignificant) parts and correct that small detail later, but it's up to you :P

Electron also had some updates to fix the shadows on client decorations iirc. Things are always improving but not yet perfect in our quirky linux lands hehe. Let's keep it incremental for now?

Regarding the decorations I was looking into improving the client side dec. to somewhat follow the desktops without hacks like libdecor if possible, but the situation itself seems inherently messy anyway. Beyond the effort an app should bear individually, more of a platform issue. Took the screenshots with system decorations either way.